Merge branch '299105-fix-remaining' into 'master'

Fix remaining Style/FrozenStringLiteralComment violations

See merge request gitlab-org/gitlab!53996

.rubocop_manual_todo.yml

@@ -2473,26 +2473,3 @@ Gitlab/NamespacedClass:
     - 'spec/support/sidekiq_middleware.rb'
     - 'spec/tasks/gitlab/task_helpers_spec.rb'
     - 'spec/uploaders/object_storage_spec.rb'
-
-# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/299105
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - 'Gemfile'
-    - 'Rakefile'
-    - 'app/views/dashboard/issues.atom.builder'
-    - 'app/views/dashboard/projects/index.atom.builder'
-    - 'app/views/events/_event.atom.builder'
-    - 'app/views/groups/issues.atom.builder'
-    - 'app/views/groups/show.atom.builder'
-    - 'app/views/issues/_issue.atom.builder'
-    - 'app/views/issues/_issues_calendar.ics.ruby'
-    - 'app/views/layouts/xml.atom.builder'
-    - 'app/views/projects/commits/_commit.atom.builder'
-    - 'app/views/projects/commits/show.atom.builder'
-    - 'app/views/projects/issues/index.atom.builder'
-    - 'app/views/projects/show.atom.builder'
-    - 'app/views/projects/tags/_tag.atom.builder'
-    - 'app/views/projects/tags/index.atom.builder'
-    - 'app/views/users/show.atom.builder'
-    - 'danger/changes_size/Dangerfile'
-    - 'danger/metadata/Dangerfile'

Gemfile

+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'rails', '~> 6.0.3.1'

Rakefile

 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

app/views/dashboard/issues.atom.builder

+# frozen_string_literal: true
+
 # rubocop: disable CodeReuse/ActiveRecord
 xml.title   "#{current_user.name} issues"
 xml.link    href: url_for(safe_params), rel: "self", type: "application/atom+xml"

app/views/dashboard/projects/index.atom.builder

+# frozen_string_literal: true
+
 xml.title   "Activity"
 xml.link    href: dashboard_projects_url(rss_url_options), rel: "self", type: "application/atom+xml"
 xml.link    href: dashboard_projects_url, rel: "alternate", type: "text/html"

app/views/events/_event.atom.builder

+# frozen_string_literal: true
+
 return unless event.visible_to_user?(current_user)
 
 event = event.present

app/views/groups/issues.atom.builder

+# frozen_string_literal: true
+
 # rubocop: disable CodeReuse/ActiveRecord
 xml.title   "#{@group.name} issues"
 xml.link    href: url_for(safe_params), rel: "self", type: "application/atom+xml"

app/views/groups/show.atom.builder

+# frozen_string_literal: true
+
 xml.title   "#{@group.name} activity"
 xml.link    href: group_url(@group, rss_url_options), rel: "self", type: "application/atom+xml"
 xml.link    href: group_url(@group), rel: "alternate", type: "text/html"

app/views/issues/_issue.atom.builder

+# frozen_string_literal: true
+
 xml.entry do
   xml.id      project_issue_url(issue.project, issue)
   xml.link    href: project_issue_url(issue.project, issue)

app/views/issues/_issues_calendar.ics.ruby

+# frozen_string_literal: true
+
 cal = Icalendar::Calendar.new
 cal.prodid = '-//GitLab//NONSGML GitLab//EN'
 cal.x_wr_calname = 'GitLab Issues'

app/views/layouts/xml.atom.builder

+# frozen_string_literal: true
+
 xml.instruct!
 xml.feed 'xmlns' => 'http://www.w3.org/2005/Atom', 'xmlns:media' => 'http://search.yahoo.com/mrss/' do
   xml << yield

app/views/projects/commits/_commit.atom.builder

+# frozen_string_literal: true
+
 xml.entry do
   xml.id      project_commit_url(@project, id: commit.id)
   xml.link    href: project_commit_url(@project, id: commit.id)

app/views/projects/commits/show.atom.builder

+# frozen_string_literal: true
+
 xml.title   "#{@project.name}:#{@ref} commits"
 xml.link    href: project_commits_url(@project, @ref, rss_url_options), rel: "self", type: "application/atom+xml"
 xml.link    href: project_commits_url(@project, @ref), rel: "alternate", type: "text/html"

app/views/projects/issues/index.atom.builder

+# frozen_string_literal: true
+
 # rubocop: disable CodeReuse/ActiveRecord
 xml.title   "#{@project.name} issues"
 xml.link    href: url_for(safe_params), rel: "self", type: "application/atom+xml"

app/views/projects/show.atom.builder

+# frozen_string_literal: true
+
 xml.title   "#{@project.name} activity"
 xml.link    href: project_url(@project, rss_url_options), rel: "self", type: "application/atom+xml"
 xml.link    href: project_url(@project), rel: "alternate", type: "text/html"

app/views/projects/tags/_tag.atom.builder

+# frozen_string_literal: true
+
 commit = @repository.commit(tag.dereferenced_target)
 release = @releases.find { |r| r.tag == tag.name }
 tag_url = project_tag_url(@project, tag.name)

app/views/projects/tags/index.atom.builder

+# frozen_string_literal: true
+
 xml.title   "#{@project.name} tags"
 xml.link    href: project_tags_url(@project, @ref, rss_url_options), rel: 'self', type: 'application/atom+xml'
 xml.link    href: project_tags_url(@project, @ref), rel: 'alternate', type: 'text/html'

app/views/users/show.atom.builder

+# frozen_string_literal: true
+
 xml.title   "#{@user.name} activity"
 xml.link    href: user_url(@user, :atom), rel: "self", type: "application/atom+xml"
 xml.link    href: user_url(@user), rel: "alternate", type: "text/html"

danger/changes_size/Dangerfile

+# frozen_string_literal: true
+
 # FIXME: git.info_for_file raises the following error
 # /usr/local/bundle/gems/git-1.4.0/lib/git/lib.rb:956:in `command':  (Danger::DSLError)
 # [!] Invalid `Dangerfile` file:

danger/metadata/Dangerfile

+# frozen_string_literal: true
+
 # rubocop:disable Style/SignalException
 
 THROUGHPUT_LABELS = [