Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
dfc5abb6
Commit
dfc5abb6
authored
Jun 22, 2021
by
Erick Banks
Committed by
Mark Lapierre
Jun 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Allow tests to click elements without page fully loading
parent
a1f4569d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
2 deletions
+4
-2
qa/qa/page/base.rb
qa/qa/page/base.rb
+4
-2
No files found.
qa/qa/page/base.rb
View file @
dfc5abb6
...
@@ -104,7 +104,8 @@ module QA
...
@@ -104,7 +104,8 @@ module QA
end
end
def
find_element
(
name
,
**
kwargs
)
def
find_element
(
name
,
**
kwargs
)
wait_for_requests
skip_finished_loading_check
=
kwargs
.
delete
(
:skip_finished_loading_check
)
wait_for_requests
(
skip_finished_loading_check:
skip_finished_loading_check
)
element_selector
=
element_selector_css
(
name
,
reject_capybara_query_keywords
(
kwargs
))
element_selector
=
element_selector_css
(
name
,
reject_capybara_query_keywords
(
kwargs
))
find
(
element_selector
,
only_capybara_query_keywords
(
kwargs
))
find
(
element_selector
,
only_capybara_query_keywords
(
kwargs
))
...
@@ -196,7 +197,8 @@ module QA
...
@@ -196,7 +197,8 @@ module QA
# replace with (..., page = self.class)
# replace with (..., page = self.class)
def
click_element
(
name
,
page
=
nil
,
**
kwargs
)
def
click_element
(
name
,
page
=
nil
,
**
kwargs
)
wait_for_requests
skip_finished_loading_check
=
kwargs
.
delete
(
:skip_finished_loading_check
)
wait_for_requests
(
skip_finished_loading_check:
skip_finished_loading_check
)
wait
=
kwargs
.
delete
(
:wait
)
||
Capybara
.
default_max_wait_time
wait
=
kwargs
.
delete
(
:wait
)
||
Capybara
.
default_max_wait_time
text
=
kwargs
.
delete
(
:text
)
text
=
kwargs
.
delete
(
:text
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment