Commit e24c4171 authored by Stan Hu's avatar Stan Hu

Remove feature flag for limiting diverging commit counts

In GitLab 12.4 via
https://gitlab.com/gitlab-org/gitlab/merge_requests/16737, we required
the frontend to request at most 20 branches in the
`Projects::BranchesController#diverging_commit_counts` endpoint to avoid
Gitaly N+1 issues. This commit removes the feature flag and makes this
behavior mandatory. In the past week, there do not appear to be any
rejections, which would show up as 422 errors.
parent 44afe919
...@@ -133,8 +133,6 @@ class Projects::BranchesController < Projects::ApplicationController ...@@ -133,8 +133,6 @@ class Projects::BranchesController < Projects::ApplicationController
# frontend could omit this set. To prevent excessive I/O, we require # frontend could omit this set. To prevent excessive I/O, we require
# that a list of names be specified. # that a list of names be specified.
def limit_diverging_commit_counts! def limit_diverging_commit_counts!
return unless Feature.enabled?(:limit_diverging_commit_counts, default_enabled: true)
limit = Kaminari.config.default_per_page limit = Kaminari.config.default_per_page
# If we don't have many branches in the repository, then go ahead. # If we don't have many branches in the repository, then go ahead.
......
---
title: Remove feature flag for limiting diverging commit counts
merge_request: 20999
author:
type: other
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment