Remove icon_size option for gl_badge_helper

- we should not allow customisation of the icon size

app/helpers/badges_helper.rb

@@ -87,12 +87,7 @@ module BadgesHelper
     if options[:icon]
       icon_classes = GL_ICON_CLASSES.dup
       icon_classes << "gl-mr-2" unless icon_only
-
-      icon = if options[:icon_size]
-               sprite_icon(options[:icon], size: options[:icon_size], css_class: icon_classes.join(' '))
-             else
-               sprite_icon(options[:icon], css_class: icon_classes.join(' '))
-             end
+      icon = sprite_icon(options[:icon], css_class: icon_classes.join(' '))
 
       content = icon_only ? icon : icon + content
     end

app/views/layouts/nav/_classification_level_banner.html.haml

 - if ::Gitlab::ExternalAuthorization.enabled? && @project
   = content_for :header_content do
-    = gl_badge_tag(@project.external_authorization_classification_label, { variant: :danger, icon: 'lock-open', icon_size: 8 }, { class: 'has-tooltip', title: s_('ExternalAuthorizationService|Classification label') })
+    = gl_badge_tag(@project.external_authorization_classification_label, { variant: :danger, icon: 'lock-open' }, { class: 'has-tooltip', title: s_('ExternalAuthorizationService|Classification label') })

spec/helpers/badges_helper_spec.rb

@@ -113,13 +113,9 @@ RSpec.describe BadgesHelper do
         it 'adds aria-label to element' do
           expect(subject).to match(%r{<span .*aria-label="#{label}".*>})
         end
-      end
-
-      describe 'icon size' do
-        subject { helper.gl_badge_tag(label, icon: 'question-o', icon_size: 8) }
 
-        it 'adds an img role to element' do
-          expect(subject).to match(%r{<svg .*class="s8.*".*>})
+        it 'does not add a spacing class to the icon' do
+          expect(subject).not_to match(spacing_class_regex)
         end
       end
     end