Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e30b7056
Commit
e30b7056
authored
Oct 28, 2020
by
Amy Qualls
Committed by
Brett Walker
Oct 30, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Apply 2 suggestion(s) to 1 file(s)
parent
929cc77d
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
4 deletions
+4
-4
doc/development/graphql_guide/pagination.md
doc/development/graphql_guide/pagination.md
+4
-4
No files found.
doc/development/graphql_guide/pagination.md
View file @
e30b7056
...
@@ -210,11 +210,11 @@ These types of queries are not supported. In these instances, you can use offset
...
@@ -210,11 +210,11 @@ These types of queries are not supported. In these instances, you can use offset
There are times when the
[
complexity of sorting
](
#limitations-of-query-complexity
)
There are times when the
[
complexity of sorting
](
#limitations-of-query-complexity
)
is more than our keyset pagination can handle.
is more than our keyset pagination can handle.
For example in
[
`IssuesResolver`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/resolvers/issues_resolver.rb
)
,
For example
,
in
[
`IssuesResolver`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/resolvers/issues_resolver.rb
)
,
when sorting by
`priority_asc`
, we can't use keyset pagination
,
as the ordering is much
when sorting by
`priority_asc`
, we can't use keyset pagination as the ordering is much
too complex
(see
[
`issuable.rb`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/concerns/issuable.rb
)
.
too complex
. For more information, read
[
`issuable.rb`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/concerns/issuable.rb
)
.
In cases like this, we can fall
back to using
regular offset pagination by returning a
In cases like this, we can fall
back to
regular offset pagination by returning a
[
`Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/graphql/pagination/offset_active_record_relation_connection.rb
)
[
`Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection`
](
https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/graphql/pagination/offset_active_record_relation_connection.rb
)
instead of an
`ActiveRecord::Relation`
instead of an
`ActiveRecord::Relation`
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment