Merge branch '32486-update-eslint-plugin-import-to-2.18.2-spec-frontend-m-r' into 'master'

Update eslint-plugin-import from 2.16.0 to 2.18.2 (/spec/frontend/[m-r]*)

See merge request gitlab-org/gitlab!21313

spec/frontend/monitoring/charts/time_series_spec.js

 import { shallowMount } from '@vue/test-utils';
 import { setTestTimeout } from 'helpers/timeout';
-import { createStore } from '~/monitoring/stores';
 import { GlLink } from '@gitlab/ui';
 import { GlAreaChart, GlLineChart, GlChartSeriesLabel } from '@gitlab/ui/dist/charts';
 import { shallowWrapperContainsSlotText } from 'helpers/vue_test_utils_helper';
+import { createStore } from '~/monitoring/stores';
 import TimeSeries from '~/monitoring/components/charts/time_series.vue';
 import * as types from '~/monitoring/stores/mutation_types';
 import {

spec/frontend/monitoring/components/charts/anomaly_spec.js

+import { shallowMount } from '@vue/test-utils';
+import { TEST_HOST } from 'helpers/test_constants';
 import Anomaly from '~/monitoring/components/charts/anomaly.vue';
 
-import { shallowMount } from '@vue/test-utils';
 import { colorValues } from '~/monitoring/constants';
 import {
   anomalyDeploymentData,
@@ -8,7 +9,6 @@ import {
   anomalyMockGraphData,
   anomalyMockResultValues,
 } from '../../mock_data';
-import { TEST_HOST } from 'helpers/test_constants';
 import MonitorTimeSeriesChart from '~/monitoring/components/charts/time_series.vue';
 
 const mockWidgets = 'mockWidgets';

spec/frontend/monitoring/embed/embed_spec.js

 import { createLocalVue, shallowMount } from '@vue/test-utils';
 import Vuex from 'vuex';
-import Embed from '~/monitoring/components/embed.vue';
 import PanelType from 'ee_else_ce/monitoring/components/panel_type.vue';
 import { TEST_HOST } from 'helpers/test_constants';
+import Embed from '~/monitoring/components/embed.vue';
 import { groups, initialState, metricsData, metricsWithData } from './mock_data';
 
 const localVue = createLocalVue();

spec/frontend/monitoring/store/actions_spec.js

 import MockAdapter from 'axios-mock-adapter';
-import Tracking from '~/tracking';
 import testAction from 'helpers/vuex_action_helper';
+import Tracking from '~/tracking';
 import axios from '~/lib/utils/axios_utils';
 import statusCodes from '~/lib/utils/http_status';
 import { backOff } from '~/lib/utils/common_utils';

spec/frontend/mr_popover/mr_popover_spec.js

-import MRPopover from '~/mr_popover/components/mr_popover';
 import { shallowMount } from '@vue/test-utils';
+import MRPopover from '~/mr_popover/components/mr_popover';
 
 describe('MR Popover', () => {
   let wrapper;

spec/frontend/notes/components/comment_form_spec.js

@@ -2,12 +2,12 @@ import $ from 'jquery';
 import { mount } from '@vue/test-utils';
 import MockAdapter from 'axios-mock-adapter';
 import Autosize from 'autosize';
+import { trimText } from 'helpers/text_helper';
 import axios from '~/lib/utils/axios_utils';
 import createStore from '~/notes/stores';
 import CommentForm from '~/notes/components/comment_form.vue';
 import * as constants from '~/notes/constants';
 import { refreshUserMergeRequestCounts } from '~/commons/nav/user_merge_requests';
-import { trimText } from 'helpers/text_helper';
 import { keyboardDownEvent } from '../../issue_show/helpers';
 import {
   loggedOutnoteableData,

spec/frontend/notes/components/discussion_actions_spec.js

-import createStore from '~/notes/stores';
 import { shallowMount, mount, createLocalVue } from '@vue/test-utils';
 import { discussionMock } from '../../notes/mock_data';
 import DiscussionActions from '~/notes/components/discussion_actions.vue';
@@ -6,6 +5,7 @@ import ReplyPlaceholder from '~/notes/components/discussion_reply_placeholder.vu
 import ResolveDiscussionButton from '~/notes/components/discussion_resolve_button.vue';
 import ResolveWithIssueButton from '~/notes/components/discussion_resolve_with_issue_button.vue';
 import JumpToNextDiscussionButton from '~/notes/components/discussion_jump_to_next_button.vue';
+import createStore from '~/notes/stores';
 
 // NOTE: clone mock_data so that it is not accidentally mutated
 const createDiscussionMock = (props = {}) =>

spec/frontend/notes/components/discussion_jump_to_next_button_spec.js

-import JumpToNextDiscussionButton from '~/notes/components/discussion_jump_to_next_button.vue';
 import { shallowMount } from '@vue/test-utils';
+import JumpToNextDiscussionButton from '~/notes/components/discussion_jump_to_next_button.vue';
 
 describe('JumpToNextDiscussionButton', () => {
   let wrapper;

spec/frontend/notes/components/discussion_reply_placeholder_spec.js

-import ReplyPlaceholder from '~/notes/components/discussion_reply_placeholder.vue';
 import { shallowMount, createLocalVue } from '@vue/test-utils';
+import ReplyPlaceholder from '~/notes/components/discussion_reply_placeholder.vue';
 
 const localVue = createLocalVue();
 const buttonText = 'Test Button Text';

spec/frontend/notes/components/discussion_resolve_button_spec.js

-import resolveDiscussionButton from '~/notes/components/discussion_resolve_button.vue';
 import { createLocalVue, shallowMount } from '@vue/test-utils';
+import resolveDiscussionButton from '~/notes/components/discussion_resolve_button.vue';
 
 const buttonTitle = 'Resolve discussion';
 

spec/frontend/notes/old_notes_spec.js

@@ -3,12 +3,12 @@
 import $ from 'jquery';
 import _ from 'underscore';
 import MockAdapter from 'axios-mock-adapter';
-import axios from '~/lib/utils/axios_utils';
-import * as urlUtility from '~/lib/utils/url_utility';
 import '~/behaviors/markdown/render_gfm';
 import { createSpyObj } from 'helpers/jest_helpers';
 import { setTestTimeoutOnce } from 'helpers/timeout';
 import { TEST_HOST } from 'helpers/test_constants';
+import * as urlUtility from '~/lib/utils/url_utility';
+import axios from '~/lib/utils/axios_utils';
 
 // These must be imported synchronously because they pull dependencies
 // from the DOM.

spec/frontend/operation_settings/components/external_dashboard_spec.js

 import { mount, shallowMount, createLocalVue } from '@vue/test-utils';
 import { GlButton, GlLink, GlFormGroup, GlFormInput } from '@gitlab/ui';
+import { TEST_HOST } from 'helpers/test_constants';
 import ExternalDashboard from '~/operation_settings/components/external_dashboard.vue';
 import store from '~/operation_settings/store';
 import axios from '~/lib/utils/axios_utils';
 import { refreshCurrentPage } from '~/lib/utils/url_utility';
 import createFlash from '~/flash';
-import { TEST_HOST } from 'helpers/test_constants';
 
 jest.mock('~/lib/utils/url_utility');
 jest.mock('~/flash');

spec/frontend/pages/profiles/show/emoji_menu_spec.js

 import $ from 'jquery';
+import { TEST_HOST } from 'helpers/test_constants';
 import axios from '~/lib/utils/axios_utils';
 import EmojiMenu from '~/pages/profiles/show/emoji_menu';
-import { TEST_HOST } from 'helpers/test_constants';
 
 describe('EmojiMenu', () => {
   const dummyEmojiTag = '<dummy></tag>';

spec/frontend/performance_bar/components/add_request_spec.js

-import AddRequest from '~/performance_bar/components/add_request.vue';
 import { shallowMount } from '@vue/test-utils';
+import AddRequest from '~/performance_bar/components/add_request.vue';
 
 describe('add request form', () => {
   let wrapper;

spec/frontend/performance_bar/components/detailed_metric_spec.js

+import { shallowMount } from '@vue/test-utils';
 import DetailedMetric from '~/performance_bar/components/detailed_metric.vue';
 import RequestWarning from '~/performance_bar/components/request_warning.vue';
-import { shallowMount } from '@vue/test-utils';
 
 describe('detailedMetric', () => {
   const createComponent = props =>

spec/frontend/performance_bar/components/performance_bar_app_spec.js

+import { shallowMount } from '@vue/test-utils';
 import PerformanceBarApp from '~/performance_bar/components/performance_bar_app.vue';
 import PerformanceBarStore from '~/performance_bar/stores/performance_bar_store';
-import { shallowMount } from '@vue/test-utils';
 
 describe('performance bar app', () => {
   const store = new PerformanceBarStore();

spec/frontend/performance_bar/components/request_selector_spec.js

-import RequestSelector from '~/performance_bar/components/request_selector.vue';
 import { shallowMount } from '@vue/test-utils';
+import RequestSelector from '~/performance_bar/components/request_selector.vue';
 
 describe('request selector', () => {
   const requests = [

spec/frontend/performance_bar/components/request_warning_spec.js

-import RequestWarning from '~/performance_bar/components/request_warning.vue';
 import { shallowMount } from '@vue/test-utils';
+import RequestWarning from '~/performance_bar/components/request_warning.vue';
 
 describe('request warning', () => {
   const htmlId = 'request-123';

spec/frontend/pipelines/graph/job_item_spec.js

-import { trimText } from 'helpers/text_helper';
 import { mount } from '@vue/test-utils';
+import { trimText } from 'helpers/text_helper';
 import JobItem from '~/pipelines/components/graph/job_item.vue';
 
 describe('pipeline graph job item', () => {

spec/frontend/pipelines/test_reports/stores/actions_spec.js

 import MockAdapter from 'axios-mock-adapter';
+import { getJSONFixture } from 'helpers/fixtures';
 import axios from '~/lib/utils/axios_utils';
 import * as actions from '~/pipelines/stores/test_reports/actions';
 import * as types from '~/pipelines/stores/test_reports/mutation_types';
-import { getJSONFixture } from 'helpers/fixtures';
 import { TEST_HOST } from '../../../helpers/test_constants';
 import testAction from '../../../helpers/vuex_action_helper';
 import createFlash from '~/flash';

spec/frontend/pipelines/test_reports/stores/getters_spec.js

+import { getJSONFixture } from 'helpers/fixtures';
 import * as getters from '~/pipelines/stores/test_reports/getters';
 import { iconForTestStatus } from '~/pipelines/stores/test_reports/utils';
-import { getJSONFixture } from 'helpers/fixtures';
 
 describe('Getters TestReports Store', () => {
   let state;

spec/frontend/pipelines/test_reports/stores/mutations_spec.js

+import { getJSONFixture } from 'helpers/fixtures';
 import * as types from '~/pipelines/stores/test_reports/mutation_types';
 import mutations from '~/pipelines/stores/test_reports/mutations';
-import { getJSONFixture } from 'helpers/fixtures';
 
 describe('Mutations TestReports Store', () => {
   let mockState;

spec/frontend/pipelines/test_reports/test_reports_spec.js

 import Vuex from 'vuex';
-import TestReports from '~/pipelines/components/test_reports/test_reports.vue';
 import { shallowMount } from '@vue/test-utils';
-import * as actions from '~/pipelines/stores/test_reports/actions';
 import { getJSONFixture } from 'helpers/fixtures';
+import TestReports from '~/pipelines/components/test_reports/test_reports.vue';
+import * as actions from '~/pipelines/stores/test_reports/actions';
 
 describe('Test reports app', () => {
   let wrapper;

spec/frontend/pipelines/test_reports/test_suite_table_spec.js

 import Vuex from 'vuex';
+import { shallowMount } from '@vue/test-utils';
+import { getJSONFixture } from 'helpers/fixtures';
 import SuiteTable from '~/pipelines/components/test_reports/test_suite_table.vue';
 import * as getters from '~/pipelines/stores/test_reports/getters';
 import { TestStatus } from '~/pipelines/constants';
-import { shallowMount } from '@vue/test-utils';
-import { getJSONFixture } from 'helpers/fixtures';
 import skippedTestCases from './mock_data';
 
 describe('Test reports suite table', () => {

spec/frontend/pipelines/test_reports/test_summary_spec.js

-import Summary from '~/pipelines/components/test_reports/test_summary.vue';
 import { mount } from '@vue/test-utils';
 import { getJSONFixture } from 'helpers/fixtures';
+import Summary from '~/pipelines/components/test_reports/test_summary.vue';
 
 describe('Test reports summary', () => {
   let wrapper;

spec/frontend/pipelines/test_reports/test_summary_table_spec.js

 import Vuex from 'vuex';
-import SummaryTable from '~/pipelines/components/test_reports/test_summary_table.vue';
-import * as getters from '~/pipelines/stores/test_reports/getters';
 import { mount, createLocalVue } from '@vue/test-utils';
 import { getJSONFixture } from 'helpers/fixtures';
+import SummaryTable from '~/pipelines/components/test_reports/test_summary_table.vue';
+import * as getters from '~/pipelines/stores/test_reports/getters';
 
 const localVue = createLocalVue();
 localVue.use(Vuex);

spec/frontend/project_find_file_spec.js

 import MockAdapter from 'axios-mock-adapter';
 import $ from 'jquery';
-import ProjectFindFile from '~/project_find_file';
-import axios from '~/lib/utils/axios_utils';
 import { TEST_HOST } from 'helpers/test_constants';
 import sanitize from 'sanitize-html';
+import ProjectFindFile from '~/project_find_file';
+import axios from '~/lib/utils/axios_utils';
 
 jest.mock('sanitize-html', () => jest.fn(val => val));
 

spec/frontend/registry/list/components/app_spec.js

 import Vue from 'vue';
 import { mount } from '@vue/test-utils';
-import registry from '~/registry/list/components/app.vue';
 import { TEST_HOST } from 'helpers/test_constants';
+import registry from '~/registry/list/components/app.vue';
 import { reposServerResponse, parsedReposServerResponse } from '../mock_data';
 
 describe('Registry List', () => {

spec/frontend/registry/list/stores/actions_spec.js

 import MockAdapter from 'axios-mock-adapter';
+import { TEST_HOST } from 'helpers/test_constants';
+import testAction from 'helpers/vuex_action_helper';
 import axios from '~/lib/utils/axios_utils';
 import * as actions from '~/registry/list/stores/actions';
 import * as types from '~/registry/list/stores/mutation_types';
-import { TEST_HOST } from 'helpers/test_constants';
-import testAction from 'helpers/vuex_action_helper';
 import createFlash from '~/flash';
 
 import {

spec/frontend/registry/settings/stores/actions_spec.js

+import testAction from 'helpers/vuex_action_helper';
 import * as actions from '~/registry/settings/stores/actions';
 import * as types from '~/registry/settings/stores/mutation_types';
-import testAction from 'helpers/vuex_action_helper';
 
 jest.mock('~/flash.js');
 

spec/frontend/releases/detail/store/actions_spec.js

 import axios from 'axios';
 import MockAdapter from 'axios-mock-adapter';
-import * as actions from '~/releases/detail/store/actions';
 import testAction from 'helpers/vuex_action_helper';
+import * as actions from '~/releases/detail/store/actions';
 import * as types from '~/releases/detail/store/mutation_types';
 import { release } from '../../mock_data';
 import state from '~/releases/detail/store/state';

spec/frontend/releases/list/components/release_block_footer_spec.js

 import { mount } from '@vue/test-utils';
-import ReleaseBlockFooter from '~/releases/list/components/release_block_footer.vue';
-import Icon from '~/vue_shared/components/icon.vue';
 import { GlLink } from '@gitlab/ui';
 import { trimText } from 'helpers/text_helper';
+import ReleaseBlockFooter from '~/releases/list/components/release_block_footer.vue';
+import Icon from '~/vue_shared/components/icon.vue';
 import { release } from '../../mock_data';
 import { convertObjectPropsToCamelCase } from '~/lib/utils/common_utils';
 

spec/frontend/releases/list/components/release_block_milestone_info_spec.js

 import { mount } from '@vue/test-utils';
 import { GlProgressBar, GlLink, GlBadge, GlButton } from '@gitlab/ui';
+import { trimText } from 'helpers/text_helper';
 import ReleaseBlockMilestoneInfo from '~/releases/list/components/release_block_milestone_info.vue';
 import { milestones } from '../../mock_data';
-import { trimText } from 'helpers/text_helper';
 import { MAX_MILESTONES_TO_DISPLAY } from '~/releases/list/constants';
 
 describe('Release block milestone info', () => {

spec/frontend/releases/list/components/release_block_spec.js

 import { mount } from '@vue/test-utils';
+import { first } from 'underscore';
 import EvidenceBlock from '~/releases/list/components/evidence_block.vue';
 import ReleaseBlock from '~/releases/list/components/release_block.vue';
 import ReleaseBlockFooter from '~/releases/list/components/release_block_footer.vue';
 import timeagoMixin from '~/vue_shared/mixins/timeago';
-import { first } from 'underscore';
 import { release } from '../../mock_data';
 import Icon from '~/vue_shared/components/icon.vue';
 import { scrollToElement } from '~/lib/utils/common_utils';

spec/frontend/reports/components/report_section_spec.js

 import Vue from 'vue';
-import reportSection from '~/reports/components/report_section.vue';
 import mountComponent, { mountComponentWithSlots } from 'helpers/vue_mount_component_helper';
+import reportSection from '~/reports/components/report_section.vue';
 
 describe('Report section', () => {
   let vm;