Merge branch 'frozen-string-lib-gitlab-even-even-more' into 'master'

Enable even more frozen string for lib/gitlab

See merge request gitlab-org/gitlab-ce!23161

changelogs/unreleased/frozen-string-lib-gitlab-even-even-more.yml

+---
+title: Enable even more frozen string for lib/gitlab
+merge_request:
+author: gfyoung
+type: performance

lib/gitlab/hook_data/base_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class BaseBuilder

lib/gitlab/hook_data/issuable_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class IssuableBuilder < BaseBuilder

lib/gitlab/hook_data/issue_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class IssueBuilder < BaseBuilder

lib/gitlab/hook_data/merge_request_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class MergeRequestBuilder < BaseBuilder

lib/gitlab/hook_data/note_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class NoteBuilder < BaseBuilder

lib/gitlab/hook_data/wiki_page_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module HookData
     class WikiPageBuilder < BaseBuilder

lib/gitlab/i18n/metadata_entry.rb

+# frozen_string_literal: true
+
 module Gitlab
   module I18n
     class MetadataEntry

lib/gitlab/i18n/po_linter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module I18n
     class PoLinter

lib/gitlab/i18n/translation_entry.rb

+# frozen_string_literal: true
+
 module Gitlab
   module I18n
     class TranslationEntry

lib/gitlab/import/logger.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Import
     class Logger < ::Gitlab::JsonLogger

lib/gitlab/import_export/after_export_strategies/base_after_export_strategy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     module AfterExportStrategies

lib/gitlab/import_export/after_export_strategies/download_notification_strategy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     module AfterExportStrategies

lib/gitlab/import_export/after_export_strategies/web_upload_strategy.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     module AfterExportStrategies

lib/gitlab/import_export/after_export_strategy_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class AfterExportStrategyBuilder

lib/gitlab/import_export/attribute_cleaner.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class AttributeCleaner

lib/gitlab/import_export/attributes_finder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class AttributesFinder

lib/gitlab/import_export/avatar_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class AvatarRestorer

lib/gitlab/import_export/avatar_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class AvatarSaver

lib/gitlab/import_export/command_line_util.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     module CommandLineUtil

lib/gitlab/import_export/error.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     Error = Class.new(StandardError)

lib/gitlab/import_export/file_importer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class FileImporter

lib/gitlab/import_export/group_project_object_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     # Given a class, it finds or creates a new object

lib/gitlab/import_export/hash_util.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class HashUtil

lib/gitlab/import_export/importer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class Importer

lib/gitlab/import_export/json_hash_builder.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     # Generates a hash that conforms with http://apidock.com/rails/Hash/to_json

lib/gitlab/import_export/lfs_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class LfsRestorer

lib/gitlab/import_export/lfs_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class LfsSaver

lib/gitlab/import_export/members_mapper.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class MembersMapper

lib/gitlab/import_export/merge_request_parser.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class MergeRequestParser

lib/gitlab/import_export/project_tree_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class ProjectTreeRestorer

lib/gitlab/import_export/project_tree_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class ProjectTreeSaver

lib/gitlab/import_export/reader.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class Reader

lib/gitlab/import_export/relation_factory.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class RelationFactory
@@ -211,7 +213,7 @@ module Gitlab
 
       def update_note_for_missing_author(author_name)
         @relation_hash['note'] = '*Blank note*' if @relation_hash['note'].blank?
-        @relation_hash['note'] += missing_author_note(@relation_hash['updated_at'], author_name)
+        @relation_hash['note'] = "#{@relation_hash['note']}#{missing_author_note(@relation_hash['updated_at'], author_name)}"
       end
 
       def admin_user?

lib/gitlab/import_export/repo_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class RepoRestorer

lib/gitlab/import_export/repo_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class RepoSaver

lib/gitlab/import_export/saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class Saver

lib/gitlab/import_export/shared.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class Shared

lib/gitlab/import_export/statistics_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class StatisticsRestorer

lib/gitlab/import_export/uploads_manager.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class UploadsManager

lib/gitlab/import_export/uploads_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class UploadsRestorer < UploadsSaver

lib/gitlab/import_export/uploads_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class UploadsSaver

lib/gitlab/import_export/version_checker.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class VersionChecker

lib/gitlab/import_export/version_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class VersionSaver

lib/gitlab/import_export/wiki_repo_saver.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class WikiRepoSaver < RepoSaver

lib/gitlab/import_export/wiki_restorer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ImportExport
     class WikiRestorer < RepoRestorer

lib/gitlab/kubernetes/config_map.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     class ConfigMap

lib/gitlab/kubernetes/helm.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/api.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/base_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/client_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/init_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/install_command.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/helm/pod.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Helm

lib/gitlab/kubernetes/namespace.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     class Namespace

lib/gitlab/kubernetes/pod.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Kubernetes
     module Pod

lib/gitlab/legacy_github_import/base_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class BaseFormatter

lib/gitlab/legacy_github_import/branch_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class BranchFormatter < BaseFormatter

lib/gitlab/legacy_github_import/client.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class Client

lib/gitlab/legacy_github_import/comment_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class CommentFormatter < BaseFormatter

lib/gitlab/legacy_github_import/importer.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class Importer

lib/gitlab/legacy_github_import/issuable_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class IssuableFormatter < BaseFormatter

lib/gitlab/legacy_github_import/issue_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class IssueFormatter < IssuableFormatter

lib/gitlab/legacy_github_import/label_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class LabelFormatter < BaseFormatter

lib/gitlab/legacy_github_import/milestone_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class MilestoneFormatter < BaseFormatter

lib/gitlab/legacy_github_import/project_creator.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class ProjectCreator

lib/gitlab/legacy_github_import/pull_request_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class PullRequestFormatter < IssuableFormatter

lib/gitlab/legacy_github_import/release_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class ReleaseFormatter < BaseFormatter

lib/gitlab/legacy_github_import/user_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class UserFormatter

lib/gitlab/legacy_github_import/wiki_formatter.rb

+# frozen_string_literal: true
+
 module Gitlab
   module LegacyGithubImport
     class WikiFormatter

lib/gitlab/manifest_import/manifest.rb

+# frozen_string_literal: true
+
 # Class to parse manifest file and build a list of repositories for import
 #
 # <manifest>

lib/gitlab/manifest_import/project_creator.rb

+# frozen_string_literal: true
+
 module Gitlab
   module ManifestImport
     class ProjectCreator

lib/gitlab/metrics/background_transaction.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     class BackgroundTransaction < Transaction

lib/gitlab/metrics/delta.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Class for calculating the difference between two numeric values.

lib/gitlab/metrics/influx_db.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module InfluxDb

lib/gitlab/metrics/instrumentation.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Module for instrumenting methods.

lib/gitlab/metrics/method_call.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Class for tracking timing information about method calls

lib/gitlab/metrics/methods.rb

+# frozen_string_literal: true
+
 # rubocop:disable Style/ClassVars
 
 module Gitlab

lib/gitlab/metrics/methods/metric_options.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Methods

lib/gitlab/metrics/metric.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Class for storing details of a single metric (label, value, etc).

lib/gitlab/metrics/null_metric.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Mocks ::Prometheus::Client::Metric and all derived metrics

lib/gitlab/metrics/prometheus.rb

+# frozen_string_literal: true
+
 require 'prometheus/client'
 
 module Gitlab

lib/gitlab/metrics/rack_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Rack middleware for tracking Rails and Grape requests.

lib/gitlab/metrics/requests_rack_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     class RequestsRackMiddleware

lib/gitlab/metrics/samplers/base_sampler.rb

+# frozen_string_literal: true
+
 require 'logger'
 
 module Gitlab

lib/gitlab/metrics/samplers/influx_sampler.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Samplers

lib/gitlab/metrics/samplers/ruby_sampler.rb

+# frozen_string_literal: true
+
 require 'prometheus/client/support/unicorn'
 
 module Gitlab

lib/gitlab/metrics/samplers/unicorn_sampler.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Samplers

lib/gitlab/metrics/sidekiq_metrics_exporter.rb

+# frozen_string_literal: true
+
 require 'webrick'
 require 'prometheus/client/rack/exporter'
 

lib/gitlab/metrics/sidekiq_middleware.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Sidekiq middleware for tracking jobs.

lib/gitlab/metrics/subscribers/action_view.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Subscribers

lib/gitlab/metrics/subscribers/active_record.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Subscribers

lib/gitlab/metrics/subscribers/rails_cache.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     module Subscribers

lib/gitlab/metrics/system.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Module for gathering system/process statistics such as the memory usage.

lib/gitlab/metrics/transaction.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     # Class for storing metrics information of a single transaction.

lib/gitlab/metrics/web_transaction.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Metrics
     class WebTransaction < Transaction
@@ -40,7 +42,7 @@ module Gitlab
         # increasing the cardinality of our metrics, we limit the number of
         # possible suffixes.
         if suffix && ALLOWED_SUFFIXES.include?(suffix)
-          action += ".#{suffix}"
+          action = "#{action}.#{suffix}"
         end
 
         { controller: controller.class.name, action: action }

lib/gitlab/middleware/go.rb

+# frozen_string_literal: true
+
 # A dumb middleware that returns a Go HTML document if the go-get=1 query string
 # is used irrespective if the namespace/project exists
 module Gitlab

lib/gitlab/middleware/multipart.rb

+# frozen_string_literal: true
+
 # Gitlab::Middleware::Multipart - a Rack::Multipart replacement
 #
 # Rack::Multipart leaves behind tempfiles in /tmp and uses valuable Ruby

lib/gitlab/middleware/rails_queue_duration.rb

+# frozen_string_literal: true
+
 # This Rack middleware is intended to measure the latency between
 # gitlab-workhorse forwarding a request to the Rails application and the
 # time this middleware is reached.

lib/gitlab/middleware/read_only.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Middleware
     class ReadOnly

lib/gitlab/middleware/read_only/controller.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Middleware
     class ReadOnly

lib/gitlab/middleware/release_env.rb

-module Gitlab # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+module Gitlab
   module Middleware
     # Some of middleware would hold env for no good reason even after the
     # request had already been processed, and we could not garbage collect

lib/gitlab/middleware/static.rb

+# frozen_string_literal: true
+
 module Gitlab
   module Middleware
     class Static < ActionDispatch::Static