Merge branch '280951-fix-creating-issue-in-jira-from-graphql' into 'master'

Improve response from Jira issue creation from vulnerability

See merge request gitlab-org/gitlab!50150

ee/app/graphql/resolvers/external_issue_resolver.rb

@@ -7,8 +7,6 @@ module Resolvers
     type Types::ExternalIssueType, null: true
 
     def resolve
-      return serialize_external_issue(object.external_issue, object.external_type) if object.external_issue.present?
-
       BatchLoader::GraphQL.for(object.external_issue_key).batch(key: object.external_type) do |external_issue_keys, loader, args|
         case args[:key]
         when 'jira'

ee/app/models/vulnerabilities/external_issue_link.rb

@@ -18,7 +18,5 @@ module Vulnerabilities
                 message: N_('already has a "created" issue link')
               },
               if: :created?
-
-    attr_accessor :external_issue
   end
 end

ee/app/services/vulnerability_external_issue_links/create_service.rb

@@ -21,7 +21,6 @@ module VulnerabilityExternalIssueLinks
         error(external_issue.errors.values)
       else
         if external_issue_link.update(external_issue_key: external_issue.id)
-          external_issue_link.external_issue = external_issue
           success
         else
           error(external_issue_link.errors.full_messages)

ee/changelogs/unreleased/280951-fix-creating-issue-in-jira-from-graphql.yml

+---
+title: Improve response from Jira issue creation from vulnerability
+merge_request: 50150
+author:
+type: fixed

ee/spec/requests/api/graphql/mutations/vulnerabilities/create_external_issue_link_spec.rb

@@ -98,10 +98,10 @@ RSpec.describe 'Creating an External Issue Link' do
           context 'and saving external issue link succeeds' do
             let(:external_issue_id) { '10000' }
 
-            it 'creates the external issue link', :aggregate_failures do
+            it 'creates the external issue link and returns nil for external issue to be fetched using query', :aggregate_failures do
               expect { post_graphql_mutation(mutation, current_user: current_user) }.to change(Vulnerabilities::ExternalIssueLink, :count).by(1)
               expect(mutation_response['errors']).to be_empty
-              expect(mutation_response.dig('externalIssueLink', 'externalIssue', 'relativeReference')).to eq('GV-5')
+              expect(mutation_response.dig('externalIssueLink', 'externalIssue')).to be_nil
             end
           end