Commit e44729df authored by Qingyu Zhao's avatar Qingyu Zhao Committed by Robert Speicher

Remove redundant code from Project::JobsController#show

parent 80ca9033
...@@ -28,11 +28,6 @@ class Projects::JobsController < Projects::ApplicationController ...@@ -28,11 +28,6 @@ class Projects::JobsController < Projects::ApplicationController
# rubocop: disable CodeReuse/ActiveRecord # rubocop: disable CodeReuse/ActiveRecord
def show def show
@pipeline = @build.pipeline
@builds = @pipeline.builds
.order('id DESC')
.present(current_user: current_user)
respond_to do |format| respond_to do |format|
format.html format.html
format.json do format.json do
......
...@@ -121,13 +121,6 @@ RSpec.describe Projects::JobsController, :clean_gitlab_redis_shared_state do ...@@ -121,13 +121,6 @@ RSpec.describe Projects::JobsController, :clean_gitlab_redis_shared_state do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
expect(assigns(:build).id).to eq(job.id) expect(assigns(:build).id).to eq(job.id)
end end
it 'has the correct build collection' do
builds = assigns(:builds).map(&:id)
expect(builds).to include(job.id, second_job.id)
expect(builds).not_to include(third_job.id)
end
end end
context 'when job does not exist' do context 'when job does not exist' do
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment