Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e4fb1f57
Commit
e4fb1f57
authored
Mar 30, 2021
by
Nicolas Dular
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide pipeline filter when no pipeline exists
parent
ccb81a57
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
0 deletions
+14
-0
app/assets/javascripts/pipelines/components/pipelines_list/pipelines.vue
...scripts/pipelines/components/pipelines_list/pipelines.vue
+1
-0
changelogs/unreleased/nicolasdular-hide-pipelines-filter-on-empty-state.yml
...sed/nicolasdular-hide-pipelines-filter-on-empty-state.yml
+5
-0
spec/frontend/pipelines/pipelines_spec.js
spec/frontend/pipelines/pipelines_spec.js
+8
-0
No files found.
app/assets/javascripts/pipelines/components/pipelines_list/pipelines.vue
View file @
e4fb1f57
...
...
@@ -313,6 +313,7 @@ export default {
</div>
<pipelines-filtered-search
v-if=
"stateToRender !== $options.stateMap.emptyState"
:project-id=
"projectId"
:params=
"validatedParams"
@
filterPipelines=
"filterPipelines"
...
...
changelogs/unreleased/nicolasdular-hide-pipelines-filter-on-empty-state.yml
0 → 100644
View file @
e4fb1f57
---
title
:
Hide pipeline filtered search when no pipeline exists
merge_request
:
57881
author
:
type
:
changed
spec/frontend/pipelines/pipelines_spec.js
View file @
e4fb1f57
...
...
@@ -515,6 +515,10 @@ describe('Pipelines', () => {
expect
(
findEmptyState
().
text
()).
toBe
(
'
There are currently no pipelines.
'
);
});
it
(
'
renders filtered search
'
,
()
=>
{
expect
(
findFilteredSearch
().
exists
()).
toBe
(
true
);
});
it
(
'
renders tab empty state finished scope
'
,
async
()
=>
{
mock
.
onGet
(
mockPipelinesEndpoint
,
{
params
:
{
scope
:
'
finished
'
,
page
:
'
1
'
}
}).
reply
(
200
,
{
pipelines
:
[],
...
...
@@ -547,6 +551,10 @@ describe('Pipelines', () => {
);
});
it
(
'
does not render filtered search
'
,
()
=>
{
expect
(
findFilteredSearch
().
exists
()).
toBe
(
false
);
});
it
(
'
does not render tabs nor buttons
'
,
()
=>
{
expect
(
findNavigationTabs
().
exists
()).
toBe
(
false
);
expect
(
findTab
(
'
all
'
).
exists
()).
toBe
(
false
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment