Remove unneeded RepositoryAlreadyMoved exception

ReplicateRepository already handles this case

app/services/projects/update_repository_storage_service.rb

@@ -5,19 +5,12 @@ module Projects
     include Gitlab::ShellAdapter
 
     Error = Class.new(StandardError)
-    RepositoryAlreadyMoved = Class.new(StandardError)
 
     def initialize(project)
       @project = project
     end
 
     def execute(new_repository_storage_key)
-      # Raising an exception is a little heavy handed but this behavior (doing
-      # nothing if the repo is already on the right storage) prevents data
-      # loss, so it is valuable for us to be able to observe it via the
-      # exception.
-      raise RepositoryAlreadyMoved if project.repository_storage == new_repository_storage_key
-
       mirror_repositories(new_repository_storage_key)
 
       mark_old_paths_for_archive

app/workers/project_update_repository_storage_worker.rb

@@ -9,7 +9,5 @@ class ProjectUpdateRepositoryStorageWorker # rubocop:disable Scalability/Idempot
     project = Project.find(project_id)
 
     ::Projects::UpdateRepositoryStorageService.new(project).execute(new_repository_storage_key)
-  rescue ::Projects::UpdateRepositoryStorageService::RepositoryAlreadyMoved
-    Rails.logger.info "#{self.class}: repository already moved: #{project}" # rubocop:disable Gitlab/RailsLogger
   end
 end

spec/services/projects/update_repository_storage_service_spec.rb

@@ -51,7 +51,7 @@ describe Projects::UpdateRepositoryStorageService do
         it 'bails out and does nothing' do
           expect do
             subject.execute(project.repository_storage)
-          end.to raise_error(described_class::RepositoryAlreadyMoved)
+          end.to raise_error(ArgumentError, /repository and source have the same storage/)
         end
       end
 

spec/support/shared_examples/services/projects/update_repository_storage_service_shared_examples.rb

@@ -85,7 +85,7 @@ RSpec.shared_examples 'moves repository to another storage' do |repository_type|
     it 'bails out and does nothing' do
       expect do
         subject.execute(project.repository_storage)
-      end.to raise_error(described_class::RepositoryAlreadyMoved)
+      end.to raise_error(ArgumentError, /repository and source have the same storage/)
     end
   end
 

spec/workers/project_update_repository_storage_worker_spec.rb

@@ -14,11 +14,5 @@ describe ProjectUpdateRepositoryStorageWorker do
 
       subject.perform(project.id, 'new_storage')
     end
-
-    it 'catches and logs RepositoryAlreadyMoved' do
-      expect(Rails.logger).to receive(:info).with(/repository already moved/)
-
-      expect { subject.perform(project.id, project.repository_storage) }.not_to raise_error
-    end
   end
 end