Fixed AdapterService class based on review

Initializing instance with cluster instead of deployment object.
Adjusted rspec file accordingly.
Fixed changelog content.

app/models/deployment_metrics.rb

@@ -13,18 +13,18 @@ class DeploymentMetrics
   end
 
   def has_metrics?
-    deployment.success? && prometheus_adapter&.can_query?
+    deployment.success? && prometheus_adapter&.configured?
   end
 
   def metrics
-    return {} unless has_metrics?
+    return {} unless has_metrics_and_can_query?
 
     metrics = prometheus_adapter.query(:deployment, deployment)
     metrics&.merge(deployment_time: deployment.finished_at.to_i) || {}
   end
 
   def additional_metrics
-    return {} unless has_metrics?
+    return {} unless has_metrics_and_can_query?
 
     metrics = prometheus_adapter.query(:additional_metrics_deployment, deployment)
     metrics&.merge(deployment_time: deployment.finished_at.to_i) || {}
@@ -47,4 +47,8 @@ class DeploymentMetrics
   def cluster_prometheus
     cluster.application_prometheus if cluster&.application_prometheus_available?
   end
+
+  def has_metrics_and_can_query?
+    has_metrics? && prometheus_adapter.can_query?
+  end
 end

app/models/environment.rb

@@ -208,7 +208,7 @@ class Environment < ApplicationRecord
   end
 
   def metrics
-    prometheus_adapter.query(:environment, self) if has_metrics? && prometheus_adapter.can_query?
+    prometheus_adapter.query(:environment, self) if has_metrics_and_can_query?
   end
 
   def prometheus_status
@@ -216,7 +216,7 @@ class Environment < ApplicationRecord
   end
 
   def additional_metrics(*args)
-    return unless has_metrics?
+    return unless has_metrics_and_can_query?
 
     prometheus_adapter.query(:additional_metrics_environment, self, *args.map(&:to_f))
   end
@@ -285,6 +285,10 @@ class Environment < ApplicationRecord
 
   private
 
+  def has_metrics_and_can_query?
+    has_metrics? && prometheus_adapter.can_query?
+  end
+
   def generate_slug
     self.slug = Gitlab::Slug::Environment.new(name).generate
   end

changelogs/unreleased/31475-fix-metrics-for-env-status.yml

+---
+title: Prevent MergeRequestsController#ci_environment_status.json from making HTTP requests
+merge_request: 21812
+author:
+type: fixed

spec/models/deployment_metrics_spec.rb

@@ -20,7 +20,7 @@ describe DeploymentMetrics do
       end
 
       context 'with a Prometheus Service' do
-        let(:prometheus_service) { instance_double(PrometheusService, can_query?: true) }
+        let(:prometheus_service) { instance_double(PrometheusService, can_query?: true, configured?: true) }
 
         before do
           allow(deployment.project).to receive(:find_or_initialize_service).with('prometheus').and_return prometheus_service
@@ -30,7 +30,17 @@ describe DeploymentMetrics do
       end
 
       context 'with a Prometheus Service that cannot query' do
-        let(:prometheus_service) { instance_double(PrometheusService, can_query?: false) }
+        let(:prometheus_service) { instance_double(PrometheusService, configured?: true, can_query?: false) }
+
+        before do
+          allow(deployment.project).to receive(:find_or_initialize_service).with('prometheus').and_return prometheus_service
+        end
+
+        it { is_expected.to be_falsy }
+      end
+
+      context 'with a Prometheus Service that is not configured' do
+        let(:prometheus_service) { instance_double(PrometheusService, configured?: false, can_query?: false) }
 
         before do
           allow(deployment.project).to receive(:find_or_initialize_service).with('prometheus').and_return prometheus_service
@@ -44,7 +54,7 @@ describe DeploymentMetrics do
         let!(:prometheus) { create(:clusters_applications_prometheus, :installed, cluster: deployment.cluster) }
 
         before do
-          expect(deployment.cluster.application_prometheus).to receive(:can_query?).and_return(true)
+          expect(deployment.cluster.application_prometheus).to receive(:configured?).and_return(true)
         end
 
         it { is_expected.to be_truthy }
@@ -54,7 +64,7 @@ describe DeploymentMetrics do
 
   describe '#metrics' do
     let(:deployment) { create(:deployment, :success) }
-    let(:prometheus_adapter) { instance_double(PrometheusService, can_query?: true) }
+    let(:prometheus_adapter) { instance_double(PrometheusService, can_query?: true, configured?: true) }
     let(:deployment_metrics) { described_class.new(deployment.project, deployment) }
 
     subject { deployment_metrics.metrics }
@@ -101,7 +111,7 @@ describe DeploymentMetrics do
         }
       end
 
-      let(:prometheus_adapter) { instance_double('prometheus_adapter', can_query?: true) }
+      let(:prometheus_adapter) { instance_double('prometheus_adapter', can_query?: true, configured?: true) }
 
       before do
         allow(deployment_metrics).to receive(:prometheus_adapter).and_return(prometheus_adapter)

spec/serializers/environment_status_entity_spec.rb

@@ -45,7 +45,7 @@ describe EnvironmentStatusEntity do
   end
 
   context 'when deployment has metrics' do
-    let(:prometheus_adapter) { double('prometheus_adapter', can_query?: true) }
+    let(:prometheus_adapter) { double('prometheus_adapter', can_query?: true, configured?: true) }
 
     let(:simple_metrics) do
       {