Merge branch 'lm-fix-error-query' into 'master'

Fixes search for error tracking list

See merge request gitlab-org/gitlab!26129

app/assets/javascripts/error_tracking/components/error_tracking_list.vue

@@ -236,6 +236,7 @@ export default {
             </gl-dropdown>
             <div class="filtered-search-input-container flex-fill">
               <gl-form-input
+                v-model="errorSearchQuery"
                 class="pl-2 filtered-search"
                 :disabled="loading"
                 :placeholder="__('Search or filter results…')"

changelogs/unreleased/lm-fix-error-query.yml

+---
+title: Fix search for Sentry error list
+merge_request: 26129
+author:
+type: fixed

spec/features/error_tracking/user_searches_sentry_errors_spec.rb

+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe 'When a user searches for Sentry errors', :js, :use_clean_rails_memory_store_caching, :sidekiq_inline do
+  include_context 'sentry error tracking context feature'
+
+  let_it_be(:issues_response_body) { fixture_file('sentry/issues_sample_response.json') }
+  let_it_be(:error_search_response_body) { fixture_file('sentry/error_list_search_response.json') }
+  let(:issues_api_url) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved" }
+  let(:issues_api_url_search) { "#{sentry_api_urls.issues_url}?limit=20&query=is:unresolved%20NotFound" }
+
+  before do
+    stub_request(:get, issues_api_url).with(
+      headers: { 'Authorization' => 'Bearer access_token_123' }
+    ).to_return(status: 200, body: issues_response_body, headers: { 'Content-Type' => 'application/json' })
+
+    stub_request(:get, issues_api_url_search).with(
+      headers: { 'Authorization' => 'Bearer access_token_123', 'Content-Type' => 'application/json' }
+    ).to_return(status: 200, body: error_search_response_body, headers: { 'Content-Type' => 'application/json' })
+  end
+
+  it 'displays the results' do
+    sign_in(project.owner)
+    visit project_error_tracking_index_path(project)
+
+    page.within(find('.gl-table')) do
+      results = page.all('.table-row')
+      expect(results.count).to be(2)
+    end
+
+    find('.gl-form-input').set('NotFound').native.send_keys(:return)
+
+    page.within(find('.gl-table')) do
+      results = page.all('.table-row')
+      expect(results.count).to be(1)
+      expect(results.first).to have_content('NotFound')
+    end
+  end
+end

spec/fixtures/sentry/error_list_search_response.json

+[{
+  "lastSeen": "2018-12-31T12:00:11Z",
+  "numComments": 0,
+  "userCount": 0,
+  "stats": {
+    "24h": [
+      [
+        1546437600,
+        0
+      ]
+    ]
+  },
+  "culprit": "sentry.tasks.reports.deliver_organization_user_report",
+  "title": "NotFound desc = GetRepoPath: not a git repository",
+  "id": "13",
+  "assignedTo": null,
+  "logger": null,
+  "type": "error",
+  "annotations": [],
+  "metadata": {
+    "type": "gaierror",
+    "value": "[Errno -2] Name or service not known"
+  },
+  "status": "unresolved",
+  "subscriptionDetails": null,
+  "isPublic": false,
+  "hasSeen": false,
+  "shortId": "INTERNAL-4",
+  "shareId": null,
+  "firstSeen": "2018-12-17T12:00:14Z",
+  "count": "17283712",
+  "permalink": "35.228.54.90/sentry/internal/issues/13/",
+  "level": "error",
+  "isSubscribed": true,
+  "isBookmarked": false,
+  "project": {
+    "slug": "internal",
+    "id": "1",
+    "name": "Internal"
+  },
+  "statusDetails": {}
+}]

spec/fixtures/sentry/issues_sample_response.json

-[{
+[
+  {
     "lastSeen": "2018-12-31T12:00:11Z",
     "numComments": 0,
     "userCount": 0,
@@ -39,4 +40,47 @@
       "name": "Internal"
     },
     "statusDetails": {}
-  }]
+  },
+  {
+    "lastSeen": "2018-12-31T12:00:11Z",
+    "numComments": 0,
+    "userCount": 0,
+    "stats": {
+      "24h": [
+        [
+          1546437600,
+          0
+        ]
+      ]
+    },
+    "culprit": "sentry.tasks.reports.deliver_organization_user_report",
+    "title": "NotFound desc = GetRepoPath: not a git repository",
+    "id": "13",
+    "assignedTo": null,
+    "logger": null,
+    "type": "error",
+    "annotations": [],
+    "metadata": {
+      "type": "gaierror",
+      "value": "GetRepoPath: not a git repository"
+    },
+    "status": "unresolved",
+    "subscriptionDetails": null,
+    "isPublic": false,
+    "hasSeen": false,
+    "shortId": "INTERNAL-4",
+    "shareId": null,
+    "firstSeen": "2018-12-17T12:00:14Z",
+    "count": "17283712",
+    "permalink": "35.228.54.90/sentry/internal/issues/13/",
+    "level": "error",
+    "isSubscribed": true,
+    "isBookmarked": false,
+    "project": {
+      "slug": "internal",
+      "id": "1",
+      "name": "Internal"
+    },
+    "statusDetails": {}
+  }
+]

spec/frontend/error_tracking/components/error_tracking_list_spec.js

@@ -42,9 +42,6 @@ describe('ErrorTrackingList', () => {
         ...stubChildren(ErrorTrackingList),
         ...stubs,
       },
-      data() {
-        return { errorSearchQuery: 'search' };
-      },
     });
   }
 
@@ -164,8 +161,9 @@ describe('ErrorTrackingList', () => {
       });
 
       it('it searches by query', () => {
+        findSearchBox().vm.$emit('input', 'search');
         findSearchBox().trigger('keyup.enter');
-        expect(actions.searchByQuery.mock.calls[0][1]).toEqual(wrapper.vm.errorSearchQuery);
+        expect(actions.searchByQuery.mock.calls[0][1]).toBe('search');
       });
 
       it('it sorts by fields', () => {

spec/lib/sentry/client/issue_spec.rb

@@ -49,7 +49,7 @@ describe Sentry::Client::Issue do
     it_behaves_like 'calls sentry api'
 
     it_behaves_like 'issues have correct return type', Gitlab::ErrorTracking::Error
-    it_behaves_like 'issues have correct length', 1
+    it_behaves_like 'issues have correct length', 2
 
     shared_examples 'has correct external_url' do
       context 'external_url' do
@@ -184,7 +184,7 @@ describe Sentry::Client::Issue do
       it_behaves_like 'calls sentry api'
 
       it_behaves_like 'issues have correct return type', Gitlab::ErrorTracking::Error
-      it_behaves_like 'issues have correct length', 1
+      it_behaves_like 'issues have correct length', 2
     end
 
     context 'when cursor is present' do
@@ -194,7 +194,7 @@ describe Sentry::Client::Issue do
       it_behaves_like 'calls sentry api'
 
       it_behaves_like 'issues have correct return type', Gitlab::ErrorTracking::Error
-      it_behaves_like 'issues have correct length', 1
+      it_behaves_like 'issues have correct length', 2
     end
   end