Commit e68f628a authored by Thomas Randolph's avatar Thomas Randolph

Switch classes to use data-testid

parent 04f9732b
...@@ -70,14 +70,14 @@ export default { ...@@ -70,14 +70,14 @@ export default {
:class="{ bold: isCompareVersionsHeader }" :class="{ bold: isCompareVersionsHeader }"
> >
<span>+</span> <span>+</span>
<span class="js-file-addition-line">{{ addedLines }}</span> <span data-testid="js-file-addition-line">{{ addedLines }}</span>
</div> </div>
<div <div
class="diff-stats-group gl-text-red-500 gl-display-flex gl-align-items-center" class="diff-stats-group gl-text-red-500 gl-display-flex gl-align-items-center"
:class="{ bold: isCompareVersionsHeader }" :class="{ bold: isCompareVersionsHeader }"
> >
<span>-</span> <span>-</span>
<span class="js-file-deletion-line">{{ removedLines }}</span> <span data-testid="js-file-deletion-line">{{ removedLines }}</span>
</div> </div>
</div> </div>
</div> </div>
......
...@@ -129,8 +129,8 @@ RSpec.describe 'Merge request > User sees versions', :js do ...@@ -129,8 +129,8 @@ RSpec.describe 'Merge request > User sees versions', :js do
) )
expect(page).to have_content '4 files' expect(page).to have_content '4 files'
additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group .js-file-addition-line').text additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-addition-line"]').text
deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group .js-file-deletion-line').text deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-deletion-line"]').text
expect(additions_content).to eq '15' expect(additions_content).to eq '15'
expect(deletions_content).to eq '6' expect(deletions_content).to eq '6'
...@@ -152,8 +152,8 @@ RSpec.describe 'Merge request > User sees versions', :js do ...@@ -152,8 +152,8 @@ RSpec.describe 'Merge request > User sees versions', :js do
end end
it 'show diff between new and old version' do it 'show diff between new and old version' do
additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group .js-file-addition-line').text additions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-addition-line"]').text
deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group .js-file-deletion-line').text deletions_content = page.find('.diff-stats.is-compare-versions-header .diff-stats-group [data-testid="js-file-deletion-line"]').text
expect(page).to have_content '4 files' expect(page).to have_content '4 files'
expect(additions_content).to eq '15' expect(additions_content).to eq '15'
......
import { GlIcon } from '@gitlab/ui'; import { GlIcon } from '@gitlab/ui';
import { shallowMount } from '@vue/test-utils'; import { shallowMount } from '@vue/test-utils';
import { extendedWrapper } from 'helpers/vue_test_utils_helper';
import DiffStats from '~/diffs/components/diff_stats.vue'; import DiffStats from '~/diffs/components/diff_stats.vue';
import mockDiffFile from '../mock_data/diff_file'; import mockDiffFile from '../mock_data/diff_file';
...@@ -12,13 +14,15 @@ describe('diff_stats', () => { ...@@ -12,13 +14,15 @@ describe('diff_stats', () => {
let wrapper; let wrapper;
const createComponent = (props = {}) => { const createComponent = (props = {}) => {
wrapper = shallowMount(DiffStats, { wrapper = extendedWrapper(
propsData: { shallowMount(DiffStats, {
addedLines: TEST_ADDED_LINES, propsData: {
removedLines: TEST_REMOVED_LINES, addedLines: TEST_ADDED_LINES,
...props, removedLines: TEST_REMOVED_LINES,
}, ...props,
}); },
}),
);
}; };
describe('diff stats group', () => { describe('diff stats group', () => {
...@@ -64,18 +68,18 @@ describe('diff_stats', () => { ...@@ -64,18 +68,18 @@ describe('diff_stats', () => {
}); });
describe('line changes', () => { describe('line changes', () => {
const findFileLine = (name) => wrapper.find(name); const findFileLine = (name) => wrapper.findByTestId(name);
beforeEach(() => { beforeEach(() => {
createComponent(); createComponent();
}); });
it('shows the amount of lines added', () => { it('shows the amount of lines added', () => {
expect(findFileLine('.js-file-addition-line').text()).toBe(TEST_ADDED_LINES.toString()); expect(findFileLine('js-file-addition-line').text()).toBe(TEST_ADDED_LINES.toString());
}); });
it('shows the amount of lines removed', () => { it('shows the amount of lines removed', () => {
expect(findFileLine('.js-file-deletion-line').text()).toBe(TEST_REMOVED_LINES.toString()); expect(findFileLine('js-file-deletion-line').text()).toBe(TEST_REMOVED_LINES.toString());
}); });
}); });
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment