Merge branch '6692-remove-geo-redownload-feature-flag' into 'master'

Resolve "Remove Geo snapshot feature flag"

Closes #6692

See merge request gitlab-org/gitlab-ee!6286

ee/app/services/geo/base_sync_service.rb

@@ -117,8 +117,6 @@ module Geo
     # will be enqueued by the log cursor, which should resolve any problems
     # it is possible to fix.
     def fetch_snapshot
-      return unless Feature.enabled?(:geo_redownload_with_snapshot)
-
       log_info("Attempting to fetch repository via snapshot")
 
       temp_repo.create_from_snapshot(

ee/changelogs/unreleased/6692-remove-geo-redownload-feature-flag.yml

+---
+title: Enable Geo snapshot synchronization for everyone
+merge_request: 6286
+author:
+type: other

ee/spec/support/services/base_sync_service_shared_examples.rb

@@ -74,30 +74,6 @@ shared_examples 'geo base sync fetch and repack' do
       fetch_repository
     end
 
-    context 'redownload' do
-      let(:fetch_repository) { subject.send(:fetch_repository, true) }
-
-      before do
-        stub_feature_flags(geo_redownload_with_snapshot: false)
-      end
-
-      it 'fetches repository from geo node into temporary location' do
-        temporary_repository = instance_double('Repository')
-
-        is_expected.to receive(:temp_repo) { temporary_repository }
-        is_expected.to receive(:fetch_geo_mirror).with(temporary_repository)
-        is_expected.to receive(:set_temp_repository_as_main)
-
-        fetch_repository
-      end
-
-      it 'schedule git repack' do
-        is_expected.to receive(:schedule_repack)
-
-        fetch_repository
-      end
-    end
-
     context 'repository does not exist' do
       before do
         allow_any_instance_of(Repository).to receive(:exists?) { false }
@@ -162,15 +138,6 @@ shared_examples 'sync retries use the snapshot RPC' do
 
         subject.execute
       end
-
-      it 'does not attempt to snapshot if the feature flag is disabled' do
-        stub_feature_flags(geo_redownload_with_snapshot: false)
-
-        expect(repository).not_to receive_create_from_snapshot
-        expect(subject).to receive(:fetch_geo_mirror).with(repository)
-
-        subject.execute
-      end
     end
   end
 end