Merge branch 'MaxWinterstein-master-patch-60978' into 'master'

Allow optional angle brackets in (Envelope-To) mail header

See merge request gitlab-org/gitlab!23797

changelogs/unreleased/MaxWinterstein-master-patch-60978.yml

+---
+title: Add optional angle brackets in address_regex
+merge_request: 23797
+author: Max Winterstein
+type: fixed

lib/gitlab/incoming_email.rb

@@ -61,7 +61,7 @@ module Gitlab
 
         regex = Regexp.escape(wildcard_address)
         regex = regex.sub(Regexp.escape(WILDCARD_PLACEHOLDER), '(.+)')
-        Regexp.new(/\A#{regex}\z/).freeze
+        Regexp.new(/\A<?#{regex}>?\z/).freeze
       end
     end
   end

spec/fixtures/emails/envelope_to_header_with_angle_brackets.eml

+Return-Path: <jake@example.com>
+Received: from myserver.example.com ([unix socket]) by myserver (Cyrus v2.2.13-Debian-2.2.13-19+squeeze3) with LMTPA; Thu, 13 Jun 2013 17:03:50 -0400
+Received: from mail.example.com (mail.example.com [IPv6:2607:f8b0:4001:c03::234]) by myserver.example.com (8.14.3/8.14.3/Debian-9.4) with ESMTP id r5DL3nFJ016967 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for <incoming+gitlabhq/gitlabhq@example.com>; Thu, 13 Jun 2013 17:03:50 -0400
+Received: by myserver.example.com with SMTP id f4so21977375iea.25 for <incoming+gitlabhq/gitlabhq@appmail.example.com>; Thu, 13 Jun 2013 14:03:48 -0700
+Received: by 10.0.0.1 with HTTP; Thu, 13 Jun 2013 14:03:48 -0700
+From: "jake@example.com" <jake@example.com>
+To: "support@example.com" <support@example.com>
+Subject: Insert hilarious subject line here
+Date: Tue, 26 Nov 2019 14:22:41 +0000
+Message-ID: <7e2296f83dbf4de388cbf5f56f52c11f@EXDAG29-1.EXCHANGE.INT>
+Accept-Language: de-DE, en-US
+Content-Language: de-DE
+X-MS-Has-Attach:
+X-MS-TNEF-Correlator:
+x-ms-exchange-transport-fromentityheader: Hosted
+x-originating-ip: [62.96.54.178]
+Content-Type: multipart/alternative;
+	boundary="_000_7e2296f83dbf4de388cbf5f56f52c11fEXDAG291EXCHANGEINT_"
+MIME-Version: 1.0
+Envelope-To: <incoming+gitlabhq/gitlabhq+auth_token@appmail.example.com>
+
+--_000_7e2296f83dbf4de388cbf5f56f52c11fEXDAG291EXCHANGEINT_
+Content-Type: text/plain; charset="iso-8859-1"
+Content-Transfer-Encoding: quoted-printable
+
+
+
+--_000_7e2296f83dbf4de388cbf5f56f52c11fEXDAG291EXCHANGEINT_
+Content-Type: text/html; charset="iso-8859-1"
+Content-Transfer-Encoding: quoted-printable
+
+Look, a message with some alternate headers! We should really support them.

spec/lib/gitlab/email/receiver_spec.rb

@@ -35,6 +35,12 @@ describe Gitlab::Email::Receiver do
 
       it_behaves_like 'correctly finds the mail key'
     end
+
+    context 'when enclosed with angle brackets in an Envelope-To header' do
+      let(:email_raw) { fixture_file('emails/envelope_to_header_with_angle_brackets.eml') }
+
+      it_behaves_like 'correctly finds the mail key'
+    end
   end
 
   context "when we cannot find a capable handler" do