Merge branch 'issue#220040-fix-rails-savebang-ci-modules' into 'master'

Fix Rails/SaveBang Rubocop offenses for ci models

See merge request gitlab-org/gitlab!58104

.rubocop_manual_todo.yml

@@ -166,8 +166,6 @@ Rails/SaveBang:
     - 'spec/lib/gitlab/auth_spec.rb'
     - 'spec/lib/gitlab/authorized_keys_spec.rb'
     - 'spec/lib/gitlab/bitbucket_server_import/importer_spec.rb'
-    - 'spec/lib/gitlab/ci/ansi2json/style_spec.rb'
-    - 'spec/lib/gitlab/ci/status/build/common_spec.rb'
     - 'spec/lib/gitlab/cycle_analytics/base_event_fetcher_spec.rb'
     - 'spec/lib/gitlab/database/custom_structure_spec.rb'
     - 'spec/lib/gitlab/database/partitioning_migration_helpers/table_management_helpers_spec.rb'

changelogs/unreleased/issue-220040-fix-rails-savebang-ci-modules.yml

+---
+title: Fix Rails/SaveBang Rubocop offenses for ci models
+merge_request: 58104
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/ci/ansi2json/style_spec.rb

@@ -160,9 +160,9 @@ RSpec.describe Gitlab::Ci::Ansi2json::Style do
     with_them do
       it 'change the style' do
         style = described_class.new
-        style.update(initial_state)
+        style.update(initial_state) # rubocop:disable Rails/SaveBang
 
-        style.update(ansi_commands)
+        style.update(ansi_commands) # rubocop:disable Rails/SaveBang
 
         expect(style.to_s).to eq(result)
       end

spec/lib/gitlab/ci/status/build/common_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe Gitlab::Ci::Status::Build::Common do
 
     context 'when user does not have access to read build' do
       before do
-        project.update(public_builds: false)
+        project.update!(public_builds: false)
       end
 
       it { is_expected.not_to have_details }