Merge branch 'frozen-string-enable-spec-lib-gitlab' into 'master'

Enable frozen string for spec/lib/gitlab

See merge request gitlab-org/gitlab!19746

spec/lib/gitlab/exclusive_lease_helpers_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::ExclusiveLeaseHelpers, :clean_gitlab_redis_shared_state do

spec/lib/gitlab/exclusive_lease_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::ExclusiveLease, :clean_gitlab_redis_shared_state do

spec/lib/gitlab/external_authorization_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::ExternalAuthorization, :request_store do

spec/lib/gitlab/fake_application_settings_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::FakeApplicationSettings do

spec/lib/gitlab/favicon_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 RSpec.describe Gitlab::Favicon, :request_store do

spec/lib/gitlab/file_detector_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::FileDetector do

spec/lib/gitlab/file_finder_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::FileFinder do

spec/lib/gitlab/git_access_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::GitAccess do

spec/lib/gitlab/git_access_wiki_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::GitAccessWiki do

spec/lib/gitlab/git_ref_validator_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::GitRefValidator do

spec/lib/gitlab/git_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Git do

spec/lib/gitlab/gitaly_client_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 # We stub Gitaly in `spec/support/gitaly.rb` for other tests. We don't want

spec/lib/gitlab/github_import_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::GithubImport do

spec/lib/gitlab/gl_repository_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe ::Gitlab::GlRepository do

spec/lib/gitlab/gpg_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Gpg do
@@ -63,7 +65,7 @@ describe Gitlab::Gpg do
     it 'downcases the email' do
       public_key = double(:key)
       fingerprints = double(:fingerprints)
-      uid = double(:uid, name: 'Nannie Bernhard', email: 'NANNIE.BERNHARD@EXAMPLE.COM')
+      uid = double(:uid, name: +'Nannie Bernhard', email: +'NANNIE.BERNHARD@EXAMPLE.COM')
       raw_key = double(:raw_key, uids: [uid])
       allow(Gitlab::Gpg::CurrentKeyChain).to receive(:fingerprints_from_key).with(public_key).and_return(fingerprints)
       allow(GPGME::Key).to receive(:find).with(:public, anything).and_return([raw_key])
@@ -78,8 +80,8 @@ describe Gitlab::Gpg do
     it 'rejects non UTF-8 names and addresses' do
       public_key = double(:key)
       fingerprints = double(:fingerprints)
-      email = "\xEEch@test.com".force_encoding('ASCII-8BIT')
-      uid = double(:uid, name: 'Test User', email: email)
+      email = (+"\xEEch@test.com").force_encoding('ASCII-8BIT')
+      uid = double(:uid, name: +'Test User', email: email)
       raw_key = double(:raw_key, uids: [uid])
       allow(Gitlab::Gpg::CurrentKeyChain).to receive(:fingerprints_from_key).with(public_key).and_return(fingerprints)
       allow(GPGME::Key).to receive(:find).with(:public, anything).and_return([raw_key])

spec/lib/gitlab/group_search_results_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::GroupSearchResults do

spec/lib/gitlab/highlight_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Highlight do

spec/lib/gitlab/http_io_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::HttpIO do

spec/lib/gitlab/http_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::HTTP do

spec/lib/gitlab/i18n_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::I18n do

spec/lib/gitlab/identifier_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Identifier do

spec/lib/gitlab/import_sources_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::ImportSources do

spec/lib/gitlab/incoming_email_spec.rb

+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Gitlab::IncomingEmail do

spec/lib/gitlab/insecure_key_fingerprint_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::InsecureKeyFingerprint do

spec/lib/gitlab/issuable_metadata_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::IssuableMetadata do

spec/lib/gitlab/issuable_sorter_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::IssuableSorter do

spec/lib/gitlab/issuables_count_for_state_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::IssuablesCountForState do

spec/lib/gitlab/job_waiter_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::JobWaiter do

spec/lib/gitlab/json_logger_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::JsonLogger do

spec/lib/gitlab/kubernetes_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Kubernetes do

spec/lib/gitlab/language_detection_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::LanguageDetection do

spec/lib/gitlab/lazy_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::Lazy do

spec/lib/gitlab/visibility_level_checker_spec.rb

+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Gitlab::VisibilityLevelChecker do