Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ebe8021a
Commit
ebe8021a
authored
Apr 22, 2018
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Merge remote-tracking branch 'upstream/master' into ce-to-ee-2018-04-22
parents
54d9b138
c212908a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
6 deletions
+6
-6
app/controllers/projects/jobs_controller.rb
app/controllers/projects/jobs_controller.rb
+0
-2
changelogs/unreleased/45625-job-log-shows-no-job-log.yml
changelogs/unreleased/45625-job-log-shows-no-job-log.yml
+5
-0
spec/controllers/projects/jobs_controller_spec.rb
spec/controllers/projects/jobs_controller_spec.rb
+1
-4
No files found.
app/controllers/projects/jobs_controller.rb
View file @
ebe8021a
...
...
@@ -78,8 +78,6 @@ class Projects::JobsController < Projects::ApplicationController
result
.
merge!
(
trace
.
to_h
)
end
result
[
:html
]
=
result
[
:html
].
presence
||
'No job log'
render
json:
result
end
end
...
...
changelogs/unreleased/45625-job-log-shows-no-job-log.yml
0 → 100644
View file @
ebe8021a
---
title
:
Removes 'No Job log' message from build trace
merge_request
:
18523
author
:
type
:
fixed
spec/controllers/projects/jobs_controller_spec.rb
View file @
ebe8021a
...
...
@@ -190,10 +190,7 @@ describe Projects::JobsController do
expect
(
response
).
to
have_gitlab_http_status
(
:ok
)
expect
(
json_response
[
'id'
]).
to
eq
job
.
id
expect
(
json_response
[
'status'
]).
to
eq
job
.
status
end
it
'returns no job log message'
do
expect
(
json_response
[
'html'
]).
to
eq
(
'No job log'
)
expect
(
json_response
[
'html'
]).
to
be_nil
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment