Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ecacb94f
Commit
ecacb94f
authored
Apr 09, 2021
by
Yogi
Committed by
Jose Ivan Vargas
Apr 09, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update popover placement and cursor on warning icon in performance bar
parent
33d97f6d
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
13 additions
and
4 deletions
+13
-4
app/assets/javascripts/performance_bar/components/request_selector.vue
...vascripts/performance_bar/components/request_selector.vue
+6
-2
app/assets/javascripts/performance_bar/components/request_warning.vue
...avascripts/performance_bar/components/request_warning.vue
+2
-2
changelogs/unreleased/pb-popover-improvement.yml
changelogs/unreleased/pb-popover-improvement.yml
+5
-0
No files found.
app/assets/javascripts/performance_bar/components/request_selector.vue
View file @
ecacb94f
...
@@ -58,9 +58,13 @@ export default {
...
@@ -58,9 +58,13 @@ export default {
<span
v-if=
"request.hasWarnings"
>
(!)
</span>
<span
v-if=
"request.hasWarnings"
>
(!)
</span>
</option>
</option>
</select>
</select>
<span
v-if=
"requestsWithWarnings.length"
>
<span
v-if=
"requestsWithWarnings.length"
class=
"gl-cursor-default"
>
<span
id=
"performance-bar-request-selector-warning"
v-html=
"glEmojiTag('warning')"
></span>
<span
id=
"performance-bar-request-selector-warning"
v-html=
"glEmojiTag('warning')"
></span>
<gl-popover
target=
"performance-bar-request-selector-warning"
:content=
"warningMessage"
/>
<gl-popover
placement=
"bottom"
target=
"performance-bar-request-selector-warning"
:content=
"warningMessage"
/>
</span>
</span>
</div>
</div>
</
template
>
</
template
>
app/assets/javascripts/performance_bar/components/request_warning.vue
View file @
ecacb94f
...
@@ -35,8 +35,8 @@ export default {
...
@@ -35,8 +35,8 @@ export default {
};
};
</
script
>
</
script
>
<
template
>
<
template
>
<span
v-if=
"hasWarnings"
>
<span
v-if=
"hasWarnings"
class=
"gl-cursor-default"
>
<span
:id=
"htmlId"
v-html=
"glEmojiTag('warning')"
></span>
<span
:id=
"htmlId"
v-html=
"glEmojiTag('warning')"
></span>
<gl-popover
:target=
"htmlId"
:content=
"warningMessage"
/>
<gl-popover
placement=
"bottom"
:target=
"htmlId"
:content=
"warningMessage"
/>
</span>
</span>
</
template
>
</
template
>
changelogs/unreleased/pb-popover-improvement.yml
0 → 100644
View file @
ecacb94f
---
title
:
Update popover placement and cursor on warning icon in PB
merge_request
:
58552
author
:
Yogi (@yo)
type
:
changed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment