Merge branch '343202-fix-review-pipeline-missing-review-deploy' into 'master'

Pass scheduled pipeline variables to child pipeline

See merge request gitlab-org/gitlab!72479

.gitlab/ci/review.gitlab-ci.yml

@@ -25,6 +25,12 @@ start-review-app-pipeline:
       artifacts: false
     - job: build-qa-image
       artifacts: false
+  # These variables are set in the pipeline schedules.
+  # They need to be explicitly passed on to the child pipeline.
+  # https://docs.gitlab.com/ee/ci/pipelines/multi_project_pipelines.html#pass-cicd-variables-to-a-downstream-pipeline-by-using-the-variables-keyword
+  variables:
+    FREQUENCY: $FREQUENCY
+    DAST_RUN: $DAST_RUN
   trigger:
     include:
       - local: .gitlab/ci/review-apps/main.gitlab-ci.yml

.gitlab/ci/rules.gitlab-ci.yml

@@ -80,7 +80,7 @@
   if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_PATH == "gitlab-org/gitlab" && $CI_PIPELINE_SOURCE == "schedule"'
 
 .if-dot-com-ee-schedule-child-pipeline: &if-dot-com-ee-schedule-child-pipeline
-  if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_PATH == "gitlab-org/gitlab" && $CI_PIPELINE_SOURCE == "parent_pipeline"'
+  if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_PATH == "gitlab-org/gitlab" && $CI_PIPELINE_SOURCE == "parent_pipeline" && $FREQUENCY'
 
 .if-dot-com-ee-2-hourly-schedule: &if-dot-com-ee-2-hourly-schedule
   if: '$CI_SERVER_HOST == "gitlab.com" && $CI_PROJECT_PATH == "gitlab-org/gitlab" && $CI_PIPELINE_SOURCE == "schedule" && $FREQUENCY == "2-hourly"'