Merge branch 'rails-save-bang-13' into 'master'

Fix Rails/SaveBang offenses for spec/support/shared_examples/services/* and ee/spec/support/shared_examples/services/*

See merge request gitlab-org/gitlab!39538

.rubocop_todo.yml

@@ -1033,8 +1033,6 @@ Rails/SaveBang:
     - 'ee/spec/support/shared_examples/models/member_shared_examples.rb'
     - 'ee/spec/support/shared_examples/models/mentionable_shared_examples.rb'
     - 'ee/spec/support/shared_examples/policies/protected_environments_shared_examples.rb'
-    - 'ee/spec/support/shared_examples/services/build_execute_shared_examples.rb'
-    - 'ee/spec/support/shared_examples/services/issue_epic_shared_examples.rb'
     - 'ee/spec/workers/adjourned_project_deletion_worker_spec.rb'
     - 'ee/spec/workers/clear_shared_runners_minutes_worker_spec.rb'
     - 'ee/spec/workers/create_github_webhook_worker_spec.rb'
@@ -1488,9 +1486,6 @@ Rails/SaveBang:
     - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
     - 'spec/support/shared_examples/quick_actions/merge_request/merge_quick_action_shared_examples.rb'
     - 'spec/support/shared_examples/serializers/note_entity_shared_examples.rb'
-    - 'spec/support/shared_examples/services/common_system_notes_shared_examples.rb'
-    - 'spec/support/shared_examples/services/issuable_shared_examples.rb'
-    - 'spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb'
     - 'spec/tasks/gitlab/web_hook_rake_spec.rb'
     - 'spec/uploaders/file_uploader_spec.rb'
     - 'spec/uploaders/object_storage_spec.rb'

changelogs/unreleased/rails-save-bang-13.yml

+---
+title: Refactor spec/support/shared_examples/services/* and ee/spec/support/shared_examples/services/* to fix Rails/SaveBang Cop
+merge_request: 39538
+author: Rajendra Kadam
+type: fixed

ee/spec/support/shared_examples/services/build_execute_shared_examples.rb

@@ -29,7 +29,7 @@ RSpec.shared_examples 'restricts access to protected environments' do |developer
 
     context 'when user has access to the environment' do
       before do
-        protected_environment.deploy_access_levels.create(user: user)
+        protected_environment.deploy_access_levels.create!(user: user)
       end
 
       it 'enqueues the build' do

ee/spec/support/shared_examples/services/issue_epic_shared_examples.rb

@@ -38,7 +38,7 @@ RSpec.shared_examples 'issue with epic_id parameter' do
 
   context 'when user can add issues to the epic' do
     before do
-      group.add_owner(user)
+      group.add_maintainer(user)
       project.add_maintainer(user)
     end
 
@@ -57,7 +57,7 @@ RSpec.shared_examples 'issue with epic_id parameter' do
       before do
         subgroup = create(:group, parent: group)
         create(:epic, group: subgroup)
-        project.update(group: subgroup)
+        project.update!(group: subgroup)
       end
 
       it 'creates epic issue link' do

spec/support/shared_examples/services/common_system_notes_shared_examples.rb

@@ -5,7 +5,7 @@ RSpec.shared_examples 'system note creation' do |update_params, note_text|
 
   before do
     issuable.assign_attributes(update_params)
-    issuable.save
+    issuable.save!
   end
 
   it 'creates 1 system note with the correct content' do

spec/support/shared_examples/services/issuable_shared_examples.rb

@@ -19,7 +19,7 @@ RSpec.shared_examples 'system notes for milestones' do
     let(:group_milestone) { create(:milestone, group: group) }
 
     before do
-      project.update(namespace: group)
+      project.update!(namespace: group)
       create(:group_member, group: group, user: user)
     end
 

spec/support/shared_examples/services/wiki_pages/destroy_service_shared_examples.rb

 # frozen_string_literal: true
 
 RSpec.shared_examples 'WikiPages::DestroyService#execute' do |container_type|
-  let(:container) { create(container_type) }
+  let(:container) { create(container_type) } # rubocop:disable Rails/SaveBang
 
   let(:user) { create(:user) }
   let(:page) { create(:wiki_page) }