Commit eee52da3 authored by Alexander Turinske's avatar Alexander Turinske Committed by Ash McKenzie

Clean up backend code

- regenerate .pot files
- update routes to not explicitly call out the controller to use
- clean up permission check
parent ac0ef446
...@@ -9,7 +9,6 @@ class Groups::Security::DashboardController < Groups::ApplicationController ...@@ -9,7 +9,6 @@ class Groups::Security::DashboardController < Groups::ApplicationController
private private
def dashboard_available? def dashboard_available?
group.feature_available?(:security_dashboard) && can?(current_user, :read_group_security_dashboard, group)
can?(current_user, :read_group_security_dashboard, group)
end end
end end
...@@ -12,8 +12,7 @@ module Groups ...@@ -12,8 +12,7 @@ module Groups
private private
def dashboard_available? def dashboard_available?
group.feature_available?(:security_dashboard) && can?(current_user, :read_group_security_dashboard, group)
can?(current_user, :read_group_security_dashboard, group)
end end
end end
end end
......
...@@ -147,7 +147,7 @@ constraints(::Constraints::GroupUrlConstrainer.new) do ...@@ -147,7 +147,7 @@ constraints(::Constraints::GroupUrlConstrainer.new) do
namespace :security do namespace :security do
resource :dashboard, only: [:show], controller: :dashboard resource :dashboard, only: [:show], controller: :dashboard
resources :vulnerabilities, only: [:index], controller: :vulnerabilities resources :vulnerabilities, only: [:index]
resource :compliance_dashboard, only: [:show] resource :compliance_dashboard, only: [:show]
resources :vulnerable_projects, only: [:index] resources :vulnerable_projects, only: [:index]
resource :discover, only: [:show], controller: :discover resource :discover, only: [:show], controller: :discover
......
...@@ -21507,9 +21507,6 @@ msgstr "" ...@@ -21507,9 +21507,6 @@ msgstr ""
msgid "SecurityReports|Fuzzing artifacts" msgid "SecurityReports|Fuzzing artifacts"
msgstr "" msgstr ""
msgid "SecurityReports|Group Security Dashboard"
msgstr ""
msgid "SecurityReports|Hide dismissed" msgid "SecurityReports|Hide dismissed"
msgstr "" msgstr ""
...@@ -21636,6 +21633,9 @@ msgstr "" ...@@ -21636,6 +21633,9 @@ msgstr ""
msgid "SecurityReports|Undo dismiss" msgid "SecurityReports|Undo dismiss"
msgstr "" msgstr ""
msgid "SecurityReports|Vulnerability Report"
msgstr ""
msgid "SecurityReports|While it's rare to have no vulnerabilities for your pipeline, it can happen. In any event, we ask that you double check your settings to make sure all security scanning jobs have passed successfully." msgid "SecurityReports|While it's rare to have no vulnerabilities for your pipeline, it can happen. In any event, we ask that you double check your settings to make sure all security scanning jobs have passed successfully."
msgstr "" msgstr ""
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment