Commit f16f315d authored by GitLab Bot's avatar GitLab Bot

Automatic merge of gitlab-org/gitlab-ce master

parents 608e8ae3 4caf0631
...@@ -27,7 +27,7 @@ When someone later changes `t.text_field :login` in the view associated with ...@@ -27,7 +27,7 @@ When someone later changes `t.text_field :login` in the view associated with
this page to `t.text_field :username` it will generate a different field this page to `t.text_field :username` it will generate a different field
identifier, what would effectively break all tests. identifier, what would effectively break all tests.
Because we are using `Page::Main::Login.act { sign_in_using_credentials }` Because we are using `Page::Main::Login.perform(&:sign_in_using_credentials)`
everywhere, when we want to sign into GitLab, the page object is the single everywhere, when we want to sign into GitLab, the page object is the single
source of truth, and we will need to update `fill_in :user_login` source of truth, and we will need to update `fill_in :user_login`
to `fill_in :user_username` only in a one place. to `fill_in :user_username` only in a one place.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment