Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f16f315d
Commit
f16f315d
authored
Jul 18, 2019
by
GitLab Bot
Browse files
Options
Browse Files
Download
Plain Diff
Automatic merge of gitlab-org/gitlab-ce master
parents
608e8ae3
4caf0631
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
1 deletion
+1
-1
doc/development/testing_guide/end_to_end/page_objects.md
doc/development/testing_guide/end_to_end/page_objects.md
+1
-1
No files found.
doc/development/testing_guide/end_to_end/page_objects.md
View file @
f16f315d
...
@@ -27,7 +27,7 @@ When someone later changes `t.text_field :login` in the view associated with
...
@@ -27,7 +27,7 @@ When someone later changes `t.text_field :login` in the view associated with
this page to
`t.text_field :username`
it will generate a different field
this page to
`t.text_field :username`
it will generate a different field
identifier, what would effectively break all tests.
identifier, what would effectively break all tests.
Because we are using
`Page::Main::Login.
act { sign_in_using_credentials }
`
Because we are using
`Page::Main::Login.
perform(&:sign_in_using_credentials)
`
everywhere, when we want to sign into GitLab, the page object is the single
everywhere, when we want to sign into GitLab, the page object is the single
source of truth, and we will need to update
`fill_in :user_login`
source of truth, and we will need to update
`fill_in :user_login`
to
`fill_in :user_username`
only in a one place.
to
`fill_in :user_username`
only in a one place.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment