Commit f1b2cf0e authored by Florie Guibert's avatar Florie Guibert

Fix issue trying to edit weight with collapsed sidebar as guest

parent faacf3dd
---
title: Fix issue trying to edit weight with collapsed sidebar as guest
merge_request: 20431
author:
type: fixed
...@@ -118,7 +118,9 @@ export default { ...@@ -118,7 +118,9 @@ export default {
} }
}, },
onCollapsedClick() { onCollapsedClick() {
this.showEditField(true); if (this.editable) {
this.showEditField(true);
}
this.collapsedAfterUpdate = true; this.collapsedAfterUpdate = true;
}, },
onSubmit(e) { onSubmit(e) {
......
...@@ -50,7 +50,38 @@ describe 'Issue Sidebar' do ...@@ -50,7 +50,38 @@ describe 'Issue Sidebar' do
end end
end end
context 'as a guest' do
before do
project.add_guest(user)
visit_issue(project, issue)
end
it 'does not have a option to edit weight' do
expect(page).not_to have_selector('.block.weight .js-weight-edit-link')
end
end
context 'as a guest, interacting with collapsed sidebar', :js do
before do
project.add_guest(user)
resize_screen_sm
visit_issue(project, issue)
end
it 'edit weight field does not appear after clicking on weight when sidebar is collapsed then expanding it' do
find('.js-weight-collapsed-block').click
# Expand sidebar
open_issue_sidebar
expect(page).not_to have_selector('.block.weight .form-control')
end
end
def visit_issue(project, issue) def visit_issue(project, issue)
visit project_issue_path(project, issue) visit project_issue_path(project, issue)
end end
def open_issue_sidebar
find('aside.right-sidebar.right-sidebar-collapsed .js-sidebar-toggle').click
find('aside.right-sidebar.right-sidebar-expanded')
end
end end
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment