Commit f23d7434 authored by Sean McGivern's avatar Sean McGivern

Merge branch 'dz-sidekiq-remove-queue' into 'master'

Update sidekiq style guide with rename/remove queue instructions

Closes #34223

See merge request !13009
parents 2209426f 921e5ab0
...@@ -36,3 +36,10 @@ slow jobs blocking work (even for different jobs) on the shared queue. ...@@ -36,3 +36,10 @@ slow jobs blocking work (even for different jobs) on the shared queue.
Each Sidekiq worker must be tested using RSpec, just like any other class. These Each Sidekiq worker must be tested using RSpec, just like any other class. These
tests should be placed in `spec/workers`. tests should be placed in `spec/workers`.
## Removing or renaming queues
Try to avoid renaming or removing queues in minor and patch releases.
During online update instance can have pending jobs and removing the queue can
lead to those jobs being stuck forever. If you can't write migration for those
Sidekiq jobs, please consider doing rename or remove queue in major release only.
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment