Commit f34a2599 authored by Etienne Baqué's avatar Etienne Baqué

Removed char substitution for event message in audit detail class

parent 5cc95e50
...@@ -24,7 +24,6 @@ module Audit ...@@ -24,7 +24,6 @@ module Audit
def action_text def action_text
action = @details.slice(*ACTIONS) action = @details.slice(*ACTIONS)
value = @details.values.first.tr('_', ' ')
case action.keys.first case action.keys.first
when :add when :add
...@@ -48,5 +47,11 @@ module Audit ...@@ -48,5 +47,11 @@ module Audit
changed.join(' ') changed.join(' ')
end end
def value
target_type = @details[:target_type].constantize
val = @details.values.first
target_type == Operations::FeatureFlag ? val : val.tr('_', ' ')
end
end end
end end
...@@ -47,6 +47,7 @@ describe Audit::Details do ...@@ -47,6 +47,7 @@ describe Audit::Details do
let(:user_member) { create(:user) } let(:user_member) { create(:user) }
let(:group) { create(:group) } let(:group) { create(:group) }
let(:member) { create(:group_member, group: group, user: user_member) } let(:member) { create(:group_member, group: group, user: user_member) }
let(:target_type) { 'User' }
let(:member_access_action) do let(:member_access_action) do
{ {
change: 'access_level', change: 'access_level',
...@@ -54,11 +55,12 @@ describe Audit::Details do ...@@ -54,11 +55,12 @@ describe Audit::Details do
to: member.human_access, to: member.human_access,
author_name: user.name, author_name: user.name,
target_id: member.id, target_id: member.id,
target_type: 'User', target_type: target_type,
target_details: member.user.name target_details: member.user.name
} }
end end
context 'when the target_type is not Operations::FeatureFlag' do
it 'humanizes add group member access action' do it 'humanizes add group member access action' do
string = described_class.humanize(member_access_action) string = described_class.humanize(member_access_action)
...@@ -66,6 +68,16 @@ describe Audit::Details do ...@@ -66,6 +68,16 @@ describe Audit::Details do
end end
end end
context 'when the target_type is Operations::FeatureFlag' do
let(:target_type) { 'Operations::FeatureFlag' }
it 'leaves access_level as it is' do
string = described_class.humanize(member_access_action)
expect(string).to eq('Changed access_level from Guest to Owner')
end
end
end
context 'deploy key' do context 'deploy key' do
let(:removal_action) do let(:removal_action) do
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment