Merge branch 'remove-ff-update-project-statistics-after-commit' into 'master'

Remove update_project_statistics_after_commit feature flag

See merge request gitlab-org/gitlab!30818

app/models/concerns/update_project_statistics.rb

@@ -68,21 +68,11 @@ module UpdateProjectStatistics
 
     def schedule_update_project_statistic(delta)
       return if delta.zero?
+      return if project.nil?
 
-      if Feature.enabled?(:update_project_statistics_after_commit, default_enabled: true)
-        # Update ProjectStatistics after the transaction
       run_after_commit do
         ProjectStatistics.increment_statistic(
           project_id, self.class.project_statistics_name, delta)
-        end
-      else
-        # Use legacy-way to update within transaction
-        ProjectStatistics.increment_statistic(
-          project_id, self.class.project_statistics_name, delta)
-      end
-
-      run_after_commit do
-        next if project.nil?
 
         Namespaces::ScheduleAggregationWorker.perform_async(
           project.namespace_id)

spec/models/ci/job_artifact_spec.rb

@@ -19,25 +19,9 @@ describe Ci::JobArtifact do
 
   it_behaves_like 'having unique enum values'
 
-  context 'with update_project_statistics_after_commit enabled' do
-    before do
-      stub_feature_flags(update_project_statistics_after_commit: true)
-    end
-
-    it_behaves_like 'UpdateProjectStatistics' do
-      subject { build(:ci_job_artifact, :archive, size: 107464) }
-    end
-  end
-
-  context 'with update_project_statistics_after_commit disabled' do
-    before do
-      stub_feature_flags(update_project_statistics_after_commit: false)
-    end
-
   it_behaves_like 'UpdateProjectStatistics' do
     subject { build(:ci_job_artifact, :archive, size: 107464) }
   end
-  end
 
   describe '.with_reports' do
     let!(:artifact) { create(:ci_job_artifact, :archive) }