Remove dependency on NoSpaceLeft

f4e59f28 · Alex Kalderimis · f7696d50 · f4e59f28 · f4e59f28
Commit f4e59f28 authored Aug 25, 2020 by Alex Kalderimis
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

app/services/issue_rebalancing_service.rb app/services/issue_rebalancing_service.rb +1 -3

app/workers/issue_rebalancing_worker.rb app/workers/issue_rebalancing_worker.rb +1 -1

No files found.
--- a/app/services/issue_rebalancing_service.rb
+++ b/app/services/issue_rebalancing_service.rb
@@ -34,9 +34,7 @@ class IssueRebalancingService
    end
    # If there are 4 billion issues, then we cannot rebalance them
-    if gap_size < RelativePositioning::MIN_GAP
+    raise TooManyIssues if gap_size < RelativePositioning::MIN_GAP
-      raise RelativePositioning::NoSpaceLeft
-    end
    start = RelativePositioning::START_POSITION - (gaps / 2) * gap_size

--- a/app/workers/issue_rebalancing_worker.rb
+++ b/app/workers/issue_rebalancing_worker.rb
@@ -11,7 +11,7 @@ class IssueRebalancingWorker # rubocop:disable Scalability/IdempotentWorker
    issue = Issue.find(issue_id)
    rebalance(issue)
-  rescue ActiveRecord::RecordNotFound, IssueRebalancingService::TooManyIssues, RelativePositioning::NoSpaceLeft => e
+  rescue ActiveRecord::RecordNotFound, IssueRebalancingService::TooManyIssues => e
    Sidekiq.logger.warn(e)
  end