Commit f5074c04 authored by Hordur Freyr Yngvason's avatar Hordur Freyr Yngvason

Fix missing known usage data event

When implementing CI template usage data tracking, we missed one
template event, causing errors. This was missed during tests because the
shared example we relied on stubbed the `track_event` method, which is
responsible for the failing validation.
parent 79fc7dd6
---
title: Fix missing known usage data event
merge_request: 53729
author:
type: fixed
...@@ -578,6 +578,11 @@ ...@@ -578,6 +578,11 @@
redis_slot: ci_templates redis_slot: ci_templates
aggregation: weekly aggregation: weekly
feature_flag: usage_data_track_ci_templates_unique_projects feature_flag: usage_data_track_ci_templates_unique_projects
- name: p_ci_templates_aws_deploy_ecs
category: ci_templates
redis_slot: ci_templates
aggregation: weekly
feature_flag: usage_data_track_ci_templates_unique_projects
- name: p_ci_templates_auto_devops_build - name: p_ci_templates_auto_devops_build
category: ci_templates category: ci_templates
redis_slot: ci_templates redis_slot: ci_templates
......
...@@ -7,7 +7,11 @@ ...@@ -7,7 +7,11 @@
RSpec.shared_examples 'tracking unique hll events' do |feature_flag| RSpec.shared_examples 'tracking unique hll events' do |feature_flag|
it 'tracks unique event' do it 'tracks unique event' do
expect(Gitlab::UsageDataCounters::HLLRedisCounter).to receive(:track_event).with(target_id, values: expected_type) expect(Gitlab::UsageDataCounters::HLLRedisCounter).to(
receive(:track_event)
.with(target_id, values: expected_type)
.and_call_original # we call original to trigger additional validations; otherwise the method is stubbed
)
request request
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment