Change button variant from success to confirm

Removed if block for button because success, info variant is deprecated

changelog: fixed

app/assets/javascripts/boards/components/board_form.vue

@@ -98,9 +98,6 @@ export default {
       return this.$options.i18n[this.currentPage].btnText;
     },
     buttonKind() {
-      if (this.isNewForm) {
-        return 'success';
-      }
       if (this.isDeleteForm) {
         return 'danger';
       }

ee/spec/frontend/boards/components/board_form_spec.js

@@ -110,7 +110,7 @@ describe('BoardForm', () => {
 
       it('passes correct primary action text and variant', () => {
         expect(findModalActionPrimary().text).toBe('Create board');
-        expect(findModalActionPrimary().attributes[0].variant).toBe('success');
+        expect(findModalActionPrimary().attributes[0].variant).toBe('confirm');
       });
 
       it('does not render delete confirmation message', () => {

spec/frontend/boards/components/board_form_spec.js

@@ -130,7 +130,7 @@ describe('BoardForm', () => {
 
       it('passes correct primary action text and variant', () => {
         expect(findModalActionPrimary().text).toBe('Create board');
-        expect(findModalActionPrimary().attributes[0].variant).toBe('success');
+        expect(findModalActionPrimary().attributes[0].variant).toBe('confirm');
       });
 
       it('does not render delete confirmation message', () => {