Commit f7c8474f authored by peterhegman's avatar peterhegman

Apply reviewer suggestions to feature test

parent ac7713f5
...@@ -35,13 +35,13 @@ describe "User views issue" do ...@@ -35,13 +35,13 @@ describe "User views issue" do
describe 'user status' do describe 'user status' do
subject { visit(project_issue_path(project, issue)) } subject { visit(project_issue_path(project, issue)) }
context 'showing status of the author of the issue' do context 'when showing status of the author of the issue' do
it_behaves_like 'showing user status' do it_behaves_like 'showing user status' do
let(:user_with_status) { issue.author } let(:user_with_status) { issue.author }
end end
end end
context 'showing status of a user who commented on an issue', :js do context 'when showing status of a user who commented on an issue', :js do
let!(:note) { create(:note, noteable: issue, project: project, author: user_with_status) } let!(:note) { create(:note, noteable: issue, project: project, author: user_with_status) }
it_behaves_like 'showing user status' do it_behaves_like 'showing user status' do
...@@ -50,8 +50,8 @@ describe "User views issue" do ...@@ -50,8 +50,8 @@ describe "User views issue" do
end end
context 'when status message has an emoji', :js do context 'when status message has an emoji', :js do
message = 'My status with an emoji' let(:message) { 'My status with an emoji' }
message_emoji = 'basketball' let(:message_emoji) { 'basketball' }
let!(:note) { create(:note, noteable: issue, project: project, author: user) } let!(:note) { create(:note, noteable: issue, project: project, author: user) }
let!(:status) { create(:user_status, user: user, emoji: 'smirk', message: "#{message} :#{message_emoji}:") } let!(:status) { create(:user_status, user: user, emoji: 'smirk', message: "#{message} :#{message_emoji}:") }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment