Commit f7f36b35 authored by Vitali Tatarintev's avatar Vitali Tatarintev

Check custom mapping params from the response

Check the custom mapping's payloadExamle and payloadAttributeMappings
from the GraphQL query response instead of check the model itself
parent ae79a7c1
...@@ -40,6 +40,10 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -40,6 +40,10 @@ RSpec.describe 'Updating an existing HTTP Integration' do
name name
active active
url url
payloadExample
payloadAttributeMappings {
fieldName
}
} }
QL QL
end end
...@@ -51,10 +55,11 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -51,10 +55,11 @@ RSpec.describe 'Updating an existing HTTP Integration' do
it 'updates integration without the custom mapping params', :aggregate_failures do it 'updates integration without the custom mapping params', :aggregate_failures do
post_graphql_mutation(mutation, current_user: current_user) post_graphql_mutation(mutation, current_user: current_user)
integration_response = mutation_response['integration']
expect(response).to have_gitlab_http_status(:success) expect(response).to have_gitlab_http_status(:success)
integration.reload expect(integration_response['payloadExample']).to eq('{}')
expect(integration.payload_example).to eq({}) expect(integration_response['payloadAttributeMappings']).to be_empty
expect(integration.payload_attribute_mapping).to eq({})
end end
end end
...@@ -116,10 +121,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -116,10 +121,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do
expect(response).to have_gitlab_http_status(:success) expect(response).to have_gitlab_http_status(:success)
expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s) expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s)
expect(integration_response['name']).to eq('Modified Name') expect(integration_response['name']).to eq('Modified Name')
expect(integration_response['payloadExample']).to eq('{}')
integration.reload expect(integration_response['payloadAttributeMappings']).to be_empty
expect(integration.payload_example).to eq({})
expect(integration.payload_attribute_mapping).to eq({})
end end
end end
...@@ -135,10 +138,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -135,10 +138,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do
expect(response).to have_gitlab_http_status(:success) expect(response).to have_gitlab_http_status(:success)
expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s) expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s)
expect(integration_response['name']).to eq('Modified Name') expect(integration_response['name']).to eq('Modified Name')
expect(integration_response['payloadExample']).to eq('{}')
integration.reload expect(integration_response['payloadAttributeMappings']).to be_empty
expect(integration.payload_example).to eq({})
expect(integration.payload_attribute_mapping).to eq({})
end end
end end
...@@ -155,6 +156,10 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -155,6 +156,10 @@ RSpec.describe 'Updating an existing HTTP Integration' do
integration { integration {
id id
name name
payloadExample
payloadAttributeMappings {
fieldName
}
} }
QL QL
end end
...@@ -168,6 +173,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do ...@@ -168,6 +173,8 @@ RSpec.describe 'Updating an existing HTTP Integration' do
expect(response).to have_gitlab_http_status(:success) expect(response).to have_gitlab_http_status(:success)
expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s) expect(integration_response['id']).to eq(GitlabSchema.id_from_object(integration).to_s)
expect(integration_response['name']).to eq('Modified Name') expect(integration_response['name']).to eq('Modified Name')
expect(integration_response['payloadExample']).not_to eq('{}')
expect(integration_response['payloadAttributeMappings']).to be_present
integration.reload integration.reload
expect(integration.payload_example).to eq(current_payload_example) expect(integration.payload_example).to eq(current_payload_example)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment