Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f8c6fd18
Commit
f8c6fd18
authored
Feb 13, 2020
by
Rémy Coutable
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make 'review-deploy' depend on 'review-build-cng' with 'needs'
Signed-off-by:
Rémy Coutable
<
remy@rymai.me
>
parent
e2ce3c1a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
.gitlab/ci/review.gitlab-ci.yml
.gitlab/ci/review.gitlab-ci.yml
+4
-1
No files found.
.gitlab/ci/review.gitlab-ci.yml
View file @
f8c6fd18
...
@@ -126,7 +126,6 @@ review-build-cng:
...
@@ -126,7 +126,6 @@ review-build-cng:
-
.default-tags
-
.default-tags
-
.default-retry
-
.default-retry
image
:
registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base
image
:
registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-charts-build-base
dependencies
:
[]
variables
:
variables
:
HOST_SUFFIX
:
"
${CI_ENVIRONMENT_SLUG}"
HOST_SUFFIX
:
"
${CI_ENVIRONMENT_SLUG}"
DOMAIN
:
"
-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
DOMAIN
:
"
-${CI_ENVIRONMENT_SLUG}.${REVIEW_APPS_DOMAIN}"
...
@@ -142,6 +141,9 @@ review-deploy:
...
@@ -142,6 +141,9 @@ review-deploy:
-
.review-workflow-base
-
.review-workflow-base
-
.review:rules:mr-and-schedule
-
.review:rules:mr-and-schedule
stage
:
review
stage
:
review
needs
:
-
job
:
review-build-cng
artifacts
:
false
allow_failure
:
true
allow_failure
:
true
before_script
:
before_script
:
-
'
[[
!
-d
"ee/"
]]
||
export
GITLAB_EDITION="ee"'
-
'
[[
!
-d
"ee/"
]]
||
export
GITLAB_EDITION="ee"'
...
@@ -169,6 +171,7 @@ review-deploy:
...
@@ -169,6 +171,7 @@ review-deploy:
extends
:
.review-workflow-base
extends
:
.review-workflow-base
environment
:
environment
:
action
:
stop
action
:
stop
dependencies
:
[]
variables
:
variables
:
# We're cloning the repo instead of downloading the script for now
# We're cloning the repo instead of downloading the script for now
# because some repos are private and CI_JOB_TOKEN cannot access files.
# because some repos are private and CI_JOB_TOKEN cannot access files.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment