Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f9c0f078
Commit
f9c0f078
authored
Apr 20, 2015
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use Nokogiri in `link_to_gfm` specs
Didn't like relying so much on Regex matches
parent
fca62467
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
22 additions
and
20 deletions
+22
-20
spec/helpers/gitlab_markdown_helper_spec.rb
spec/helpers/gitlab_markdown_helper_spec.rb
+22
-20
No files found.
spec/helpers/gitlab_markdown_helper_spec.rb
View file @
f9c0f078
...
@@ -168,43 +168,45 @@ describe GitlabMarkdownHelper do
...
@@ -168,43 +168,45 @@ describe GitlabMarkdownHelper do
end
end
end
end
describe
"#link_to_gfm"
do
describe
'#link_to_gfm'
do
let
(
:commit_path
)
{
namespace_project_commit_path
(
project
.
namespace
,
project
,
commit
)
}
let
(
:commit_path
)
{
namespace_project_commit_path
(
project
.
namespace
,
project
,
commit
)
}
let
(
:issues
)
{
create_list
(
:issue
,
2
,
project:
project
)
}
let
(
:issues
)
{
create_list
(
:issue
,
2
,
project:
project
)
}
it
"should handle references nested in links with all the text"
do
it
'should handle references nested in links with all the text'
do
actual
=
link_to_gfm
(
"This should finally fix #
#{
issues
[
0
].
iid
}
and #
#{
issues
[
1
].
iid
}
for real"
,
commit_path
)
actual
=
link_to_gfm
(
"This should finally fix #
#{
issues
[
0
].
iid
}
and #
#{
issues
[
1
].
iid
}
for real"
,
commit_path
)
doc
=
Nokogiri
::
HTML
.
parse
(
actual
)
# Break the result into groups of links with their content, without
# closing tags
groups
=
actual
.
split
(
"</a>"
)
# Leading commit link
# Leading commit link
expect
(
groups
[
0
]).
to
match
(
/href="
#{
commit_path
}
"/
)
expect
(
doc
.
css
(
'a'
)[
0
].
attr
(
'href'
)).
to
eq
commit_path
expect
(
groups
[
0
]).
to
match
(
/This should finally fix $/
)
expect
(
doc
.
css
(
'a'
)[
0
].
text
).
to
eq
'This should finally fix '
# First issue link
# First issue link
expect
(
groups
[
1
]
).
expect
(
doc
.
css
(
'a'
)[
1
].
attr
(
'href'
)
).
to
match
(
/href="
#{
namespace_project_issue_path
(
project
.
namespace
,
project
,
issues
[
0
])
}
"/
)
to
eq
namespace_project_issue_path
(
project
.
namespace
,
project
,
issues
[
0
]
)
expect
(
groups
[
1
]).
to
match
(
/#
#{
issues
[
0
].
iid
}
$/
)
expect
(
doc
.
css
(
'a'
)[
1
].
text
).
to
eq
"#
#{
issues
[
0
].
iid
}
"
# Internal commit link
# Internal commit link
expect
(
groups
[
2
]).
to
match
(
/href="
#{
commit_path
}
"/
)
expect
(
doc
.
css
(
'a'
)[
2
].
attr
(
'href'
)).
to
eq
commit_path
expect
(
groups
[
2
]).
to
match
(
/ and /
)
expect
(
doc
.
css
(
'a'
)[
2
].
text
).
to
eq
' and '
# Second issue link
# Second issue link
expect
(
groups
[
3
]
).
expect
(
doc
.
css
(
'a'
)[
3
].
attr
(
'href'
)
).
to
match
(
/href="
#{
namespace_project_issue_path
(
project
.
namespace
,
project
,
issues
[
1
])
}
"/
)
to
eq
namespace_project_issue_path
(
project
.
namespace
,
project
,
issues
[
1
]
)
expect
(
groups
[
3
]).
to
match
(
/#
#{
issues
[
1
].
iid
}
$/
)
expect
(
doc
.
css
(
'a'
)[
3
].
text
).
to
eq
"#
#{
issues
[
1
].
iid
}
"
# Trailing commit link
# Trailing commit link
expect
(
groups
[
4
]).
to
match
(
/href="
#{
commit_path
}
"/
)
expect
(
doc
.
css
(
'a'
)[
4
].
attr
(
'href'
)).
to
eq
commit_path
expect
(
groups
[
4
]).
to
match
(
/ for real$/
)
expect
(
doc
.
css
(
'a'
)[
4
].
text
).
to
eq
' for real'
end
end
it
"should forward HTML options"
do
it
'should forward HTML options'
do
actual
=
link_to_gfm
(
"Fixed in
#{
commit
.
id
}
"
,
commit_path
,
class:
'foo'
)
actual
=
link_to_gfm
(
"Fixed in
#{
commit
.
id
}
"
,
commit_path
,
class:
'foo'
)
expect
(
actual
).
to
have_selector
'a.gfm.gfm-commit.foo'
doc
=
Nokogiri
::
HTML
.
parse
(
actual
)
expect
(
doc
.
css
(
'a'
)).
to
satisfy
do
|
v
|
# 'foo' gets added to all links
v
.
all?
{
|
a
|
a
.
attr
(
'class'
).
match
(
/foo$/
)
}
end
end
end
it
"escapes HTML passed in as the body"
do
it
"escapes HTML passed in as the body"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment