Commit fa3c8f90 authored by Karthick Venkatesan's avatar Karthick Venkatesan Committed by Denys Mishunov

Fix minor spacing issue at Snippet blob viewer

Prior to this change,
The padding between the two button groups in the header of a blob view for snippets is an HTML whitespace, so about 3.95px. According to Pajamas, spacing for this should actually be 8px.

How issue is resloved ?,
 After enabling Vue Snippet, the horizontal margin was set using mx-2 class to button group. the extra inline spacing was removed by making the parent class as flexbox.

Changes made in following files :
blob_header_viewer_switcher.vue - adding right padding
blob_header.vue - making the header element as flex
parent 4c434b8f
...@@ -66,7 +66,7 @@ export default { ...@@ -66,7 +66,7 @@ export default {
</template> </template>
</blob-filepath> </blob-filepath>
<div class="file-actions d-none d-sm-block"> <div class="file-actions d-none d-sm-flex">
<viewer-switcher v-if="showViewerSwitcher" v-model="viewer" /> <viewer-switcher v-if="showViewerSwitcher" v-model="viewer" />
<slot name="actions"></slot> <slot name="actions"></slot>
......
...@@ -45,7 +45,7 @@ export default { ...@@ -45,7 +45,7 @@ export default {
}; };
</script> </script>
<template> <template>
<gl-button-group class="js-blob-viewer-switcher ml-2"> <gl-button-group class="js-blob-viewer-switcher mx-2">
<gl-deprecated-button <gl-deprecated-button
v-gl-tooltip.hover v-gl-tooltip.hover
:aria-label="$options.SIMPLE_BLOB_VIEWER_TITLE" :aria-label="$options.SIMPLE_BLOB_VIEWER_TITLE"
......
---
title: Fix minor spacing issue at Snippet blob viewer
merge_request: 29625
author: Karthick Venkatesan
type: fixed
...@@ -9,7 +9,7 @@ exports[`Blob Header Default Actions rendering matches the snapshot 1`] = ` ...@@ -9,7 +9,7 @@ exports[`Blob Header Default Actions rendering matches the snapshot 1`] = `
/> />
<div <div
class="file-actions d-none d-sm-block" class="file-actions d-none d-sm-flex"
> >
<viewer-switcher-stub <viewer-switcher-stub
value="simple" value="simple"
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment