Skip to content

G
gitlab-ce
Commit fbdc8921 authored by Ash McKenzie's avatar Ash McKenzie
Browse files
Options

Merge branch 'refactor-api-group-packge-specs-license' into 'master' 

Refactor group package api specs

See merge request gitlab-org/gitlab!38522
parents bcbb31f6 1d9949f4
Hide whitespace changes
Inline Side-by-side
Showing with 90 additions and 92 deletions
spec/requests/api/group_packages_spec.rb
View file @ fbdc8921
...@@ -13,135 +13,133 @@ RSpec.describe API::GroupPackages do ...@@ -13,135 +13,133 @@ RSpec.describe API::GroupPackages do
let(:url) { "/groups/#{group.id}/packages" } let(:url) { "/groups/#{group.id}/packages" }
let(:package_schema) { 'public_api/v4/packages/group_packages' } let(:package_schema) { 'public_api/v4/packages/group_packages' }
context 'without the need for a license' do context 'with sorting' do
context 'with sorting' do let_it_be(:package1) { create(:npm_package, project: project, version: '3.1.0', name: "@#{project.root_namespace.path}/foo1") }
let_it_be(:package1) { create(:npm_package, project: project, version: '3.1.0', name: "@#{project.root_namespace.path}/foo1") } let_it_be(:package2) { create(:nuget_package, project: project, version: '2.0.4') }
let_it_be(:package2) { create(:nuget_package, project: project, version: '2.0.4') } let(:package3) { create(:maven_package, project: project, version: '1.1.1', name: 'zzz') }
let(:package3) { create(:maven_package, project: project, version: '1.1.1', name: 'zzz') }
before do
before do travel_to(1.day.ago) do
travel_to(1.day.ago) do package3
package3
end
end end
end
context 'without sorting params' do context 'without sorting params' do
let(:packages) { [package3, package1, package2] } let(:packages) { [package3, package1, package2] }
it 'sorts by created_at asc' do it 'sorts by created_at asc' do
subject subject
expect(json_response.map { |package| package['id'] }).to eq(packages.map(&:id)) expect(json_response.map { |package| package['id'] }).to eq(packages.map(&:id))
end
end end
end
it_behaves_like 'package sorting', 'name' do it_behaves_like 'package sorting', 'name' do
let(:packages) { [package1, package2, package3] } let(:packages) { [package1, package2, package3] }
end end
it_behaves_like 'package sorting', 'created_at' do it_behaves_like 'package sorting', 'created_at' do
let(:packages) { [package3, package1, package2] } let(:packages) { [package3, package1, package2] }
end end
it_behaves_like 'package sorting', 'version' do it_behaves_like 'package sorting', 'version' do
let(:packages) { [package3, package2, package1] } let(:packages) { [package3, package2, package1] }
end end
it_behaves_like 'package sorting', 'type' do it_behaves_like 'package sorting', 'type' do
let(:packages) { [package3, package1, package2] } let(:packages) { [package3, package1, package2] }
end end
it_behaves_like 'package sorting', 'project_path' do it_behaves_like 'package sorting', 'project_path' do
let(:another_project) { create(:project, :public, namespace: group, name: 'project B') } let(:another_project) { create(:project, :public, namespace: group, name: 'project B') }
let!(:package4) { create(:npm_package, project: another_project, version: '3.1.0', name: "@#{project.root_namespace.path}/bar") } let!(:package4) { create(:npm_package, project: another_project, version: '3.1.0', name: "@#{project.root_namespace.path}/bar") }
let(:packages) { [package1, package2, package3, package4] } let(:packages) { [package1, package2, package3, package4] }
end
end end
end
context 'with private group' do context 'with private group' do
let!(:package1) { create(:package, project: project) } let!(:package1) { create(:package, project: project) }
let!(:package2) { create(:package, project: project) } let!(:package2) { create(:package, project: project) }
let(:group) { create(:group, :private) } let(:group) { create(:group, :private) }
let(:subgroup) { create(:group, :private, parent: group) } let(:subgroup) { create(:group, :private, parent: group) }
let(:project) { create(:project, :private, namespace: group) } let(:project) { create(:project, :private, namespace: group) }
let(:subproject) { create(:project, :private, namespace: subgroup) } let(:subproject) { create(:project, :private, namespace: subgroup) }
context 'with unauthenticated user' do context 'with unauthenticated user' do
it_behaves_like 'rejects packages access', :group, :no_type, :not_found it_behaves_like 'rejects packages access', :group, :no_type, :not_found
end end
context 'with authenticated user' do
subject { get api(url, user) }
it_behaves_like 'returns packages', :group, :owner
it_behaves_like 'returns packages', :group, :maintainer
it_behaves_like 'returns packages', :group, :developer
it_behaves_like 'rejects packages access', :group, :reporter, :forbidden
it_behaves_like 'rejects packages access', :group, :guest, :forbidden
context 'with authenticated user' do context 'with subgroup' do
subject { get api(url, user) } let(:subgroup) { create(:group, :private, parent: group) }
let(:subproject) { create(:project, :private, namespace: subgroup) }
let!(:package3) { create(:npm_package, project: subproject) }
it_behaves_like 'returns packages', :group, :owner it_behaves_like 'returns packages with subgroups', :group, :owner
it_behaves_like 'returns packages', :group, :maintainer it_behaves_like 'returns packages with subgroups', :group, :maintainer
it_behaves_like 'returns packages', :group, :developer it_behaves_like 'returns packages with subgroups', :group, :developer
it_behaves_like 'rejects packages access', :group, :reporter, :forbidden it_behaves_like 'rejects packages access', :group, :reporter, :forbidden
it_behaves_like 'rejects packages access', :group, :guest, :forbidden it_behaves_like 'rejects packages access', :group, :guest, :forbidden
context 'with subgroup' do context 'excluding subgroup' do
let(:subgroup) { create(:group, :private, parent: group) } let(:url) { "/groups/#{group.id}/packages?exclude_subgroups=true" }
let(:subproject) { create(:project, :private, namespace: subgroup) }
let!(:package3) { create(:npm_package, project: subproject) }
it_behaves_like 'returns packages with subgroups', :group, :owner it_behaves_like 'returns packages', :group, :owner
it_behaves_like 'returns packages with subgroups', :group, :maintainer it_behaves_like 'returns packages', :group, :maintainer
it_behaves_like 'returns packages with subgroups', :group, :developer it_behaves_like 'returns packages', :group, :developer
it_behaves_like 'rejects packages access', :group, :reporter, :forbidden it_behaves_like 'rejects packages access', :group, :reporter, :forbidden
it_behaves_like 'rejects packages access', :group, :guest, :forbidden it_behaves_like 'rejects packages access', :group, :guest, :forbidden
context 'excluding subgroup' do
let(:url) { "/groups/#{group.id}/packages?exclude_subgroups=true" }
it_behaves_like 'returns packages', :group, :owner
it_behaves_like 'returns packages', :group, :maintainer
it_behaves_like 'returns packages', :group, :developer
it_behaves_like 'rejects packages access', :group, :reporter, :forbidden
it_behaves_like 'rejects packages access', :group, :guest, :forbidden
end
end end
end end
end end
end
context 'with public group' do context 'with public group' do
let_it_be(:package1) { create(:package, project: project) } let_it_be(:package1) { create(:package, project: project) }
let_it_be(:package2) { create(:package, project: project) } let_it_be(:package2) { create(:package, project: project) }
context 'with unauthenticated user' do context 'with unauthenticated user' do
it_behaves_like 'returns packages', :group, :no_type it_behaves_like 'returns packages', :group, :no_type
end end
context 'with authenticated user' do context 'with authenticated user' do
subject { get api(url, user) } subject { get api(url, user) }
it_behaves_like 'returns packages', :group, :owner it_behaves_like 'returns packages', :group, :owner
it_behaves_like 'returns packages', :group, :maintainer it_behaves_like 'returns packages', :group, :maintainer
it_behaves_like 'returns packages', :group, :developer it_behaves_like 'returns packages', :group, :developer
it_behaves_like 'returns packages', :group, :reporter it_behaves_like 'returns packages', :group, :reporter
it_behaves_like 'returns packages', :group, :guest it_behaves_like 'returns packages', :group, :guest
end
end end
end
context 'with pagination params' do context 'with pagination params' do
let_it_be(:package1) { create(:package, project: project) } let_it_be(:package1) { create(:package, project: project) }
let_it_be(:package2) { create(:package, project: project) } let_it_be(:package2) { create(:package, project: project) }
let_it_be(:package3) { create(:npm_package, project: project) } let_it_be(:package3) { create(:npm_package, project: project) }
let_it_be(:package4) { create(:npm_package, project: project) } let_it_be(:package4) { create(:npm_package, project: project) }
it_behaves_like 'returns paginated packages' it_behaves_like 'returns paginated packages'
end end
it_behaves_like 'filters on each package_type', is_project: false it_behaves_like 'filters on each package_type', is_project: false
context 'does not accept non supported package_type value' do context 'does not accept non supported package_type value' do
include_context 'package filter context' include_context 'package filter context'
let(:url) { group_filter_url(:type, 'foo') } let(:url) { group_filter_url(:type, 'foo') }
it_behaves_like 'returning response status', :bad_request it_behaves_like 'returning response status', :bad_request
end
end end
end end
end end
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7