Epic Boards - Drag & Drop epic between lists

Review feedback

app/assets/javascripts/boards/stores/actions.js

@@ -356,7 +356,7 @@ export default {
       })
       .then(({ data }) => {
         if (data?.issueMoveList?.errors.length) {
-          commit(types.MOVE_ISSUE_FAILURE, { originalIssue, fromListId, toListId, originalIndex });
+          throw new Error();
         } else {
           const issue = data.issueMoveList?.issue;
           commit(types.MOVE_ISSUE_SUCCESS, { issue });

ee/app/assets/javascripts/boards/stores/actions.js

@@ -528,7 +528,7 @@ export default {
       })
       .then(({ data }) => {
         if (data?.issueMoveList?.errors.length) {
-          commit(types.MOVE_ISSUE_FAILURE, { originalIssue, fromListId, toListId, originalIndex });
+          throw new Error();
         } else {
           const issue = data.issueMoveList?.issue;
           commit(types.MOVE_ISSUE_SUCCESS, { issue });
@@ -565,7 +565,7 @@ export default {
       })
       .then(({ data }) => {
         if (data?.epicMoveList?.errors.length) {
-          commit(types.MOVE_EPIC_FAILURE, { originalEpic, fromListId, toListId, originalIndex });
+          throw new Error();
         }
       })
       .catch(() =>

ee/spec/frontend/boards/stores/actions_spec.js

@@ -1002,7 +1002,7 @@ describe('moveEpic', () => {
     issuableType: 'epic',
   };
 
-  it('should commit MOVE_EPIC mutation mutation when successful', (done) => {
+  it('should commit MOVE_EPIC mutation mutation when successful', async () => {
     jest.spyOn(gqlClient, 'mutate').mockResolvedValue({
       data: {
         epicMoveList: {
@@ -1011,15 +1011,15 @@ describe('moveEpic', () => {
       },
     });
 
-    testAction(
-      actions.moveEpic,
-      {
+    await testAction({
+      action: actions.moveEpic,
+      payload: {
         itemId: '41',
         fromListId: 'gid://gitlab/List/1',
         toListId: 'gid://gitlab/List/2',
       },
       state,
-      [
+      expectedMutations: [
         {
           type: types.MOVE_EPIC,
           payload: {
@@ -1029,12 +1029,10 @@ describe('moveEpic', () => {
           },
         },
       ],
-      [],
-      done,
-    );
+    });
   });
 
-  it('should commit MOVE_EPIC mutation and MOVE_EPIC_FAILURE mutation when unsuccessful', (done) => {
+  it('should commit MOVE_EPIC mutation and MOVE_EPIC_FAILURE mutation when unsuccessful', async () => {
     jest.spyOn(gqlClient, 'mutate').mockResolvedValue({
       data: {
         epicMoveList: {
@@ -1043,15 +1041,15 @@ describe('moveEpic', () => {
       },
     });
 
-    testAction(
-      actions.moveEpic,
-      {
+    await testAction({
+      action: actions.moveEpic,
+      payload: {
         itemId: '41',
         fromListId: 'gid://gitlab/List/1',
         toListId: 'gid://gitlab/List/2',
       },
       state,
-      [
+      expectedMutations: [
         {
           type: types.MOVE_EPIC,
           payload: {
@@ -1070,9 +1068,7 @@ describe('moveEpic', () => {
           },
         },
       ],
-      [],
-      done,
-    );
+    });
   });
 });