Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ff6826fc
Commit
ff6826fc
authored
Mar 30, 2021
by
Jacques Erasmus
Committed by
Brandon Labuschagne
Mar 30, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use Source Editor to view blobs
Use Source editor (editor lite) to view blobs
parent
8cea5e29
Changes
9
Show whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
181 additions
and
96 deletions
+181
-96
app/assets/javascripts/blob/components/blob_content.vue
app/assets/javascripts/blob/components/blob_content.vue
+7
-0
app/assets/javascripts/repository/components/blob_content_viewer.vue
...javascripts/repository/components/blob_content_viewer.vue
+7
-0
app/assets/javascripts/repository/pages/blob.vue
app/assets/javascripts/repository/pages/blob.vue
+9
-4
app/assets/javascripts/vue_shared/components/blob_viewers/mixins.js
.../javascripts/vue_shared/components/blob_viewers/mixins.js
+10
-0
app/assets/javascripts/vue_shared/components/blob_viewers/simple_viewer.vue
...ipts/vue_shared/components/blob_viewers/simple_viewer.vue
+32
-21
spec/frontend/repository/components/blob_content_viewer_spec.js
...rontend/repository/components/blob_content_viewer_spec.js
+1
-0
spec/frontend/repository/pages/blob_spec.js
spec/frontend/repository/pages/blob_spec.js
+25
-0
spec/frontend/vue_shared/components/blob_viewers/__snapshots__/simple_viewer_spec.js.snap
...nts/blob_viewers/__snapshots__/simple_viewer_spec.js.snap
+72
-70
spec/frontend/vue_shared/components/blob_viewers/simple_viewer_spec.js
.../vue_shared/components/blob_viewers/simple_viewer_spec.js
+18
-1
No files found.
app/assets/javascripts/blob/components/blob_content.vue
View file @
ff6826fc
...
@@ -21,6 +21,11 @@ export default {
...
@@ -21,6 +21,11 @@ export default {
default
:
''
,
default
:
''
,
required
:
false
,
required
:
false
,
},
},
isRawContent
:
{
type
:
Boolean
,
default
:
false
,
required
:
false
,
},
loading
:
{
loading
:
{
type
:
Boolean
,
type
:
Boolean
,
default
:
true
,
default
:
true
,
...
@@ -65,6 +70,8 @@ export default {
...
@@ -65,6 +70,8 @@ export default {
v-else
v-else
ref=
"contentViewer"
ref=
"contentViewer"
:content=
"content"
:content=
"content"
:is-raw-content=
"isRawContent"
:file-name=
"blob.name"
:type=
"activeViewer.fileType"
:type=
"activeViewer.fileType"
data-qa-selector=
"file_content"
data-qa-selector=
"file_content"
/>
/>
...
...
app/assets/javascripts/repository/components/blob_content_viewer.vue
View file @
ff6826fc
...
@@ -36,6 +36,12 @@ export default {
...
@@ -36,6 +36,12 @@ export default {
blobHash
:
uniqueId
(),
blobHash
:
uniqueId
(),
};
};
},
},
props
:
{
path
:
{
type
:
String
,
required
:
true
,
},
},
data
()
{
data
()
{
return
{
return
{
projectPath
:
''
,
projectPath
:
''
,
...
@@ -85,6 +91,7 @@ export default {
...
@@ -85,6 +91,7 @@ export default {
<blob-content
<blob-content
:blob=
"blobInfo"
:blob=
"blobInfo"
:content=
"blobInfo.rawBlob"
:content=
"blobInfo.rawBlob"
:is-raw-content=
"true"
:active-viewer=
"viewer"
:active-viewer=
"viewer"
:loading=
"false"
:loading=
"false"
/>
/>
...
...
app/assets/javascripts/repository/pages/blob.vue
View file @
ff6826fc
...
@@ -2,16 +2,21 @@
...
@@ -2,16 +2,21 @@
// This file is in progress and behind a feature flag, please see the following issue for more:
// This file is in progress and behind a feature flag, please see the following issue for more:
// https://gitlab.com/gitlab-org/gitlab/-/issues/323200
// https://gitlab.com/gitlab-org/gitlab/-/issues/323200
// TODO (follow-up MR):
import BlobContentViewer from '../components/blob_content_viewer.vue';
import
BlobContentViewer
from
'
../components/blob_content_viewer.vue
'
;
export
default
{
export
default
{
components
:
{
components
:
{
// TODO (follow-up MR): BlobContentViewer,
BlobContentViewer
,
},
props
:
{
path
:
{
type
:
String
,
required
:
true
,
},
},
},
};
};
</
script
>
</
script
>
<
template
>
<
template
>
<div></div>
<blob-content-viewer
:path=
"path"
/>
<!-- TODO (follow-up MR):
<blob-content-viewer/>
-->
</
template
>
</
template
>
app/assets/javascripts/vue_shared/components/blob_viewers/mixins.js
View file @
ff6826fc
...
@@ -11,6 +11,16 @@ export default {
...
@@ -11,6 +11,16 @@ export default {
type
:
String
,
type
:
String
,
required
:
true
,
required
:
true
,
},
},
isRawContent
:
{
type
:
Boolean
,
default
:
false
,
required
:
false
,
},
fileName
:
{
type
:
String
,
required
:
false
,
default
:
''
,
},
},
},
mounted
()
{
mounted
()
{
eventHub
.
$emit
(
SNIPPET_MEASURE_BLOBS_CONTENT
);
eventHub
.
$emit
(
SNIPPET_MEASURE_BLOBS_CONTENT
);
...
...
app/assets/javascripts/vue_shared/components/blob_viewers/simple_viewer.vue
View file @
ff6826fc
<
script
>
<
script
>
/* eslint-disable vue/no-v-html */
/* eslint-disable vue/no-v-html */
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
{
GlIcon
}
from
'
@gitlab/ui
'
;
import
EditorLite
from
'
~/vue_shared/components/editor_lite.vue
'
;
import
{
HIGHLIGHT_CLASS_NAME
}
from
'
./constants
'
;
import
{
HIGHLIGHT_CLASS_NAME
}
from
'
./constants
'
;
import
ViewerMixin
from
'
./mixins
'
;
import
ViewerMixin
from
'
./mixins
'
;
export
default
{
export
default
{
components
:
{
components
:
{
GlIcon
,
GlIcon
,
EditorLite
,
},
},
mixins
:
[
ViewerMixin
],
mixins
:
[
ViewerMixin
],
inject
:
[
'
blobHash
'
],
inject
:
[
'
blobHash
'
],
...
@@ -45,7 +47,15 @@ export default {
...
@@ -45,7 +47,15 @@ export default {
};
};
</
script
>
</
script
>
<
template
>
<
template
>
<div>
<editor-lite
v-if=
"isRawContent"
:value=
"content"
:file-name=
"fileName"
:editor-options=
"
{ readOnly: true }"
/>
<div
<div
v-else
class=
"file-content code js-syntax-highlight"
class=
"file-content code js-syntax-highlight"
data-qa-selector=
"file_content"
data-qa-selector=
"file_content"
:class=
"$options.userColorScheme"
:class=
"$options.userColorScheme"
...
@@ -68,4 +78,5 @@ export default {
...
@@ -68,4 +78,5 @@ export default {
<pre
class=
"code highlight"
><code
:data-blob-hash=
"blobHash"
v-html=
"content"
></code></pre>
<pre
class=
"code highlight"
><code
:data-blob-hash=
"blobHash"
v-html=
"content"
></code></pre>
</div>
</div>
</div>
</div>
</div>
</
template
>
</
template
>
spec/frontend/repository/components/blob_content_viewer_spec.js
View file @
ff6826fc
...
@@ -76,6 +76,7 @@ describe('Blob content viewer component', () => {
...
@@ -76,6 +76,7 @@ describe('Blob content viewer component', () => {
expect
(
findBlobContent
().
props
(
'
loading
'
)).
toEqual
(
false
);
expect
(
findBlobContent
().
props
(
'
loading
'
)).
toEqual
(
false
);
expect
(
findBlobContent
().
props
(
'
content
'
)).
toEqual
(
'
raw content
'
);
expect
(
findBlobContent
().
props
(
'
content
'
)).
toEqual
(
'
raw content
'
);
expect
(
findBlobContent
().
props
(
'
isRawContent
'
)).
toBe
(
true
);
expect
(
findBlobContent
().
props
(
'
activeViewer
'
)).
toEqual
({
expect
(
findBlobContent
().
props
(
'
activeViewer
'
)).
toEqual
({
fileType
:
'
text
'
,
fileType
:
'
text
'
,
tooLarge
:
false
,
tooLarge
:
false
,
...
...
spec/frontend/repository/pages/blob_spec.js
0 → 100644
View file @
ff6826fc
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
BlobContentViewer
from
'
~/repository/components/blob_content_viewer.vue
'
;
import
BlobPage
from
'
~/repository/pages/blob.vue
'
;
jest
.
mock
(
'
~/repository/utils/dom
'
);
describe
(
'
Repository blob page component
'
,
()
=>
{
let
wrapper
;
const
findBlobContentViewer
=
()
=>
wrapper
.
find
(
BlobContentViewer
);
const
path
=
'
file.js
'
;
beforeEach
(()
=>
{
wrapper
=
shallowMount
(
BlobPage
,
{
propsData
:
{
path
}
});
});
afterEach
(()
=>
{
wrapper
.
destroy
();
});
it
(
'
has a Blob Content Viewer component
'
,
()
=>
{
expect
(
findBlobContentViewer
().
exists
()).
toBe
(
true
);
expect
(
findBlobContentViewer
().
props
(
'
path
'
)).
toBe
(
path
);
});
});
spec/frontend/vue_shared/components/blob_viewers/__snapshots__/simple_viewer_spec.js.snap
View file @
ff6826fc
// Jest Snapshot v1, https://goo.gl/fbAQLP
// Jest Snapshot v1, https://goo.gl/fbAQLP
exports[`Blob Simple Viewer component rendering matches the snapshot 1`] = `
exports[`Blob Simple Viewer component rendering matches the snapshot 1`] = `
<div
<div>
<div
class="file-content code js-syntax-highlight"
class="file-content code js-syntax-highlight"
data-qa-selector="file_content"
data-qa-selector="file_content"
>
>
<div
<div
class="line-numbers"
class="line-numbers"
>
>
...
@@ -83,5 +84,6 @@ exports[`Blob Simple Viewer component rendering matches the snapshot 1`] = `
...
@@ -83,5 +84,6 @@ exports[`Blob Simple Viewer component rendering matches the snapshot 1`] = `
</code>
</code>
</pre>
</pre>
</div>
</div>
</div>
</div>
</div>
`;
`;
spec/frontend/vue_shared/components/blob_viewers/simple_viewer_spec.js
View file @
ff6826fc
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
{
shallowMount
}
from
'
@vue/test-utils
'
;
import
{
HIGHLIGHT_CLASS_NAME
}
from
'
~/vue_shared/components/blob_viewers/constants
'
;
import
{
HIGHLIGHT_CLASS_NAME
}
from
'
~/vue_shared/components/blob_viewers/constants
'
;
import
SimpleViewer
from
'
~/vue_shared/components/blob_viewers/simple_viewer.vue
'
;
import
SimpleViewer
from
'
~/vue_shared/components/blob_viewers/simple_viewer.vue
'
;
import
EditorLite
from
'
~/vue_shared/components/editor_lite.vue
'
;
describe
(
'
Blob Simple Viewer component
'
,
()
=>
{
describe
(
'
Blob Simple Viewer component
'
,
()
=>
{
let
wrapper
;
let
wrapper
;
const
contentMock
=
`<span id="LC1">First</span>\n<span id="LC2">Second</span>\n<span id="LC3">Third</span>`
;
const
contentMock
=
`<span id="LC1">First</span>\n<span id="LC2">Second</span>\n<span id="LC3">Third</span>`
;
const
blobHash
=
'
foo-bar
'
;
const
blobHash
=
'
foo-bar
'
;
function
createComponent
(
content
=
contentMock
)
{
function
createComponent
(
content
=
contentMock
,
isRawContent
=
false
)
{
wrapper
=
shallowMount
(
SimpleViewer
,
{
wrapper
=
shallowMount
(
SimpleViewer
,
{
provide
:
{
provide
:
{
blobHash
,
blobHash
,
...
@@ -15,6 +16,8 @@ describe('Blob Simple Viewer component', () => {
...
@@ -15,6 +16,8 @@ describe('Blob Simple Viewer component', () => {
propsData
:
{
propsData
:
{
content
,
content
,
type
:
'
text
'
,
type
:
'
text
'
,
fileName
:
'
test.js
'
,
isRawContent
,
},
},
});
});
}
}
...
@@ -83,4 +86,18 @@ describe('Blob Simple Viewer component', () => {
...
@@ -83,4 +86,18 @@ describe('Blob Simple Viewer component', () => {
});
});
});
});
});
});
describe
(
'
raw content
'
,
()
=>
{
const
findEditorLite
=
()
=>
wrapper
.
find
(
EditorLite
);
const
isRawContent
=
true
;
it
(
'
uses the Editor Lite component in readonly mode when viewing raw content
'
,
()
=>
{
createComponent
(
'
raw content
'
,
isRawContent
);
expect
(
findEditorLite
().
exists
()).
toBe
(
true
);
expect
(
findEditorLite
().
props
(
'
value
'
)).
toBe
(
'
raw content
'
);
expect
(
findEditorLite
().
props
(
'
fileName
'
)).
toBe
(
'
test.js
'
);
expect
(
findEditorLite
().
props
(
'
editorOptions
'
)).
toEqual
({
readOnly
:
true
});
});
});
});
});
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment