Merge branch '34372-serverless-function-description-does-not-show-up-for-newly-created-functions' into 'master'

Resolve "Serverless function description missing on Knative 0.7"

Closes #34372

See merge request gitlab-org/gitlab!18973

Can directly add approvers to approval rule

Closes #30695

See merge request gitlab-org/gitlab!18965

- remove add button
- no more pillbox
- approvers will be automatically added when selected

GraphQL: Add Merge Request milestone mutation

See merge request gitlab-org/gitlab!19257

Add ability to select a Cluster management project

See merge request gitlab-org/gitlab!18928

Added a project management dropdown filter

Add ETag caching for the pod logs json API

See merge request gitlab-org/gitlab!18950

- ETag caching will help reduce the load from polling the API.
- Query parameters are not supported with ETag caching since the
middleware only looks at the request path.

Modify the frontend to work with path params

We've changed the pod logs API to use path params instead of
query params in order to support ETag caching.

Simpify api replacing patterns

- Use a single object as a parameter
- Remove some code
- Update specs

Separate out html and json logs endpoints

- Create separate APIs for the logs HTML page and the JSON endpoint
that returns k8s logs.
- Also correct the route for the JSON endpoint by adding the resource
names to the route.

Setup postgres for graphql-reference-verify

Closes #35518

See merge request gitlab-org/gitlab!19540

Create lib to read internal Prometheus address from config

See merge request gitlab-org/gitlab!19503

- Create the lib since it needs to be called in PrometheusService as
well as the current SelfMonitoring::Project::CreateService.

Metrics: Save changes in the panels in dashboard to vuex store

See merge request gitlab-org/gitlab!18862

Quarantine flaky add file template specs

See merge request gitlab-org/gitlab!19541

Update rspec guidelines for aggregating failures

See merge request gitlab-org/gitlab!19512

- Typically when we write tests, we try to only use one
  expectation per test.  However, that isn't always optimal.
  So in those cases where we have more than one expectation,
  we should try to use :aggregate_failures in order to see
  all the failures in a test block at once and not have to
  piecemeal through it as we get each to pass.

Merge branch '34418-admin-setting-integrations-incorrectly-report-validation-errors-in-ui' into 'master'

Remove unrelated errors from individual integrations

Closes #34418

See merge request gitlab-org/gitlab!18814

- before when any of the integrations had a form error,
  all of them would display that message block.
- now we have contained those error messages to the areas
  they affect.

Disable autodevops in Secure MR tests

See merge request gitlab-org/gitlab!19516

See https://gitlab.com/gitlab-org/gitlab/issues/34551

Rename terminal_max_retention_time to session_timeout

See merge request gitlab-org/gitlab!19349

docs - Sort variables' reference in ascending order

See merge request gitlab-org/gitlab!19156

Docs: Fix typo in visual_review_discussions.md title - properly display it is from starter only

See merge request gitlab-org/gitlab!19522

Docs: Remove typo

See merge request gitlab-org/gitlab!19534

Docs: Add comma after introductory phrase.

See merge request gitlab-org/gitlab!19528

Increase certmanager install timeout

See merge request gitlab-org/gitlab!19447

We have been getting reports from users that the cluster
issuer is not ready prior to timing out, failing the
installation. Since this time is primarily spent on the
cluster and not in Sidekiq, we can probably afford to wait
a bit longer.

See e.g. https://gitlab.com/gitlab-org/gitlab/issues/33186

Quarantine Jenkins build status spec

See merge request gitlab-org/gitlab!19499

Issue https://gitlab.com/gitlab-org/gitlab/issues/35370
Spec fails on staging.

Reduce use of note style in contiguous blocks of text

See merge request gitlab-org/gitlab!19336

Quarantine cluster health spec

See merge request gitlab-org/gitlab!19505

Issue https://gitlab.com/gitlab-org/gitlab/issues/35429

Improve cleanup of gpg-homedirs

See merge request gitlab-org/gitlab!19311

The `gpg-agent` that could have been spawned here dies when it sees
it's socket disappear.

However, sometimes it seems like we fail to delete the homedir,
causing the `gpg-agent` to live on forever. We've noticed that the
deletion failed in
http://gitlab.com/gitlab-org/gitlab-foss/issues/36998: there was a
race condition during the deletion where `gpg-agent` would still be
modifying files while we've already called `FileUtils.remove_entry`.

This will attempt to delete the directory multiple times, at least 0.1
seconds apart. This is a naive way of trying to make sure
we clean up the homedir and count on `gpg-agent` to see that and make
itself go away.

On a web node we'll attempt for at most 0.5 seconds to clean up the
directory before failing. In a sidekiq process we'll attempt the
deletion for up to 2 seconds.

When the cleanup fails, we will now track that exception in
Sentry to gain some visibility.

This also adds counters for the creation and deletion of tmp
keychains, which we should be able to correlate to the nubmer of
zombie `gpg-agent` processes.

Allow emojis to have links

Closes #24891

See merge request gitlab-org/gitlab!18014