- 15 Oct, 2016 16 commits
-
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
-
Bryce Johnson authored
- Tab between register and sign in forms - Add individual input validation error messages - Validate username - Update many styles for all login-box forms
-
- 14 Oct, 2016 24 commits
-
-
Annabel Dunstone Gray authored
Enforce TrailingSemicolon and EmptyLineBetweenBlocks in scss-lint ## What does this MR do? Enforces two new scss-lint rules 1. TrailingSemicolon 2. EmptyLineBetweenBlocks ## Are there points in the code the reviewer needs to double check? Make sure I didn't break anything
😁 ## Why was this MR needed? Improve our SCSS, Lessen the burden of catching these during the review process ## Screenshots (if relevant) NOne ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23319 See merge request !6903 -
Clement Ho authored
-
Fatih Acet authored
Added subnav to all views bar issuable views ## What does this MR do? Adds subnav to all views apart from issue and MR views. The full list is available in screenshots below. It also adds some JS to the builds page to simply handle the repositioning of the fixed position sidebar with the addition of the subnav. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? ~UX and apparently ~regression . ## What are the relevant issue numbers? Closes #18844. ## Screenshots (if relevant) ### Label #### Edit  #### New  ### Milestone #### Edit  #### New  #### Show  ### Commit #### Show  #### Builds  ### Blob #### Blame  #### Edit  ### Pipelines #### Show  #### Show build  #### Edit Envrionment  ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) Closes #18844 See merge request !5998
-
Fatih Acet authored
Improved specificity of toggleable file headers ## What does this MR do? Improves the specificity of the diff file title toggle styling. ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? Currently, any `.file-title` will have a pointer cursor and background colour change on hover. This should be only for diff files, except discussion diff files. ## Screenshots (if relevant)  ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23147 See merge request !6887
-
Annabel Dunstone Gray authored
Improve tabbing usability for sign in page ## What does this MR do? Rearranged the html elements so that the `sign in` button gets tabbed first before the other elements and used CSS to rearrange the visual layout. I did not use `tabindex` because it does not play well with screen readers and is not recommended from an accessibility standpoint. ## Are there points in the code the reviewer needs to double check? * Need to make sure that there aren't any side effects to my code change. `.new_user` seemed to be automatically added through `form_for()` and I'm not sure if there will be other cases where `.new_user` is used where there is no sign in page with forget your password. ## Why was this MR needed? Improves the tabbing order ## Screenshots (if relevant) None ## Does this MR meet the acceptance criteria? - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? Closes #23279 See merge request !6867
-
Fatih Acet authored
Resolve "Build/Pipeline/Environment List Inconsistency Row Height" #### What does this MR do? * Changes generic table class from `builds` to `ci-table`. It was getting confusing using `builds` for `builds`, `pipelines`, `environments` * Sets height on builds rows for continuity #### Are there points in the code the reviewer needs to double check? Apparently you can't set `min-height` on any `table` elements but you _can_ set `height`. For some reason, even if the content within happens to start wrapping, the row height will grow instead of letting the content overlap. Which is a good thing. Just kind of weird. #### Why was this MR needed? Different row heights on builds depending on content #### Screenshots (if relevant) Before:  After:  Before:  After:  ## What are the relevant issue numbers? Closes #23167 See merge request !6787
-
Fatih Acet authored
Merge request tabs stick when scrolling page ## What does this MR do? When scrolling merge requests this sticks the tabs to below the navigation for easy access. ## Screenshots (if relevant)  ## What are the relevant issue numbers? Closes #20548 See merge request !6382
-
Fatih Acet authored
Rename pipeline.js.es6 to pipelines.js.es6 ## What does this MR do? Rename pipeline.js.es6 to pipelines.js.es6 ## Are there points in the code the reviewer needs to double check? ## Why was this MR needed? `class Pipelines` not `class Pipeline` ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if it does - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? See merge request !6897
-
Stan Hu authored
Add docs for request profiling See merge request !6901
-
Rémy Coutable authored
Remove '/u' prefix form username from Account page ## What does this MR do? Removes `/u` prefix for username from Account page Fixes #23323 See merge request !6872
-
Ahmad Sherif authored
Closes #23239
-
Rémy Coutable authored
Fix empty import URL errors CE version of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/780 See merge request !6693
-
Rémy Coutable authored
Loads GFM once for per page ## What does this MR do? Currently the GFM init code is included every time there is a GFM form on the page. This changes that & only includes in once if any number of GFM forms are on the page. ## What are the relevant issue numbers? #22827 See merge request !6840
-
Rémy Coutable authored
Update README.md This fixes some broken links in our documentation See merge request !6857
-
Luke "Jared" Bennett authored
-
Kamil Trzciński authored
Execute pipeline hooks asynchronously ## What does this MR do? This MR makes it possible to execute pipeline hooks asynchronously, what should help to improve performance of CI pipeline processing. ## What are the relevant issue numbers? Closes #23056 See merge request !6824
-
Jacob Schatz authored
Increased performance of GL dropdown renderItem ## What does this MR do? - Fixes an issue where `renderItem` is called several times even when not required - Increased performance when rendering dropdown items - When using the `gl_dropdown.renderItem` it cuts the render time in approx. half. The main part holding it back now is finding the input to work out if it selected or not. ## What are the relevant issue numbers? Closes #21110 See merge request !6222
-
Rémy Coutable authored
Use gitlab-workhorse 0.8.5 ## What does this MR do? Bump gitlab-workhorse to 0.8.5 ## Why was this MR needed? Fixes to the diff and patch endpoints. See https://gitlab.com/gitlab-org/gitlab-workhorse/merge_requests/68#note_16919390 See merge request !6891
-
Rémy Coutable authored
Remove a period that can be annoying I looked through the labels, not even `P1` or `customer+` was able to really capture the importance of this MR and what it means for the future of GitLab. ## What does this MR do? It removes the period `.` at the end of the following line in the `Documentation` **Merge Request Template** `See the general Documentation guidelines http://docs.gitlab.com/ce/development/doc_styleguide.html.` ## Why was this MR needed? Because, while editing the MR `Description` the link is not clickable, so it is very easy to copy the link with the period `.` and then it ends up behaving like a broken link. I only realized that it was not a broken link because I was busy trying to find someone to fix the broken link. See merge request !6890
-
Yorick Peterse authored
Use module_function in Banzai::Renderer See merge request !6886
-
Kamil Trzcinski authored
-
Jacob Schatz authored
Validate user id for users select autcomplete ## What does this MR do? Adds digit validation to user_id when build user autocomplete URL for select2. ## Why was this MR needed? To prevent building invalid URL for non existing users like GET "/autocomplete/users/whatever@example.com.json". As result it fixes failing test: ``` Feature: Admin Groups Scenario: Invite user to a group by e-mail✔ Given I sign in as an admin # features/steps/shared/authentication.rb:11✔ And I have group with projects # features/steps/admin/groups.rb:17✔ And User "John Doe" exists # features/steps/shared/user.rb:4✔ And I visit admin groups page # features/steps/shared/paths.rb:194✔ When I visit admin group page # features/steps/admin/groups.rb:9✔ When I select user "johndoe@gitlab.com" from user list as "Reporter" # features/steps/admin/groups.rb:48✔ Then I should see "johndoe@gitlab.com" in team list in every project as "Reporter" # features/steps/admin/groups.rb:63 /Users/dzaporozhets/.rvm/gems/ruby-2.3.1/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call': No route matches [GET] "/autocomplete/users/johndoe@gitlab.com.json" (ActionController::RoutingError) ``` See merge request !6889 -
Dmitriy Zaporozhets authored
-
Yorick Peterse authored
Using `extend self` prevents GitLab Performance Monitoring from being able to track class methods. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23347
-
