- 17 Mar, 2021 1 commit
-
-
Dylan Griffith authored
Without this we receive an exception `undefined method `preloaded_records' for nil:NilClass` when trying to call `Note.includes(noteable: {assignees: []})` if any of the notes are on a `Commit`. The reason this seems to happen is due to a refactoring in Rails preloaders in https://github.com/rails/rails/commit/2847653869ffc1ff5139c46e520c72e26618c199#diff-6d659f140c909c5a70850ec69eab0014834ffb371029ccf7554b6a421a1fb0ca which expects the `#run` method to return the preloader (you can see other examples updated to return `self`). It is possible longer term that this may be made redundant by some much larger refactoring happening to this code in https://github.com/rails/rails/pull/41385 since it appears this no longer relies on the return value of `#run`. But that is not released yet and we may end up with more problems to solve when we upgrade to that.
-
- 16 Mar, 2021 39 commits
-
-
Evan Read authored
Update code_quality.md - Code Climate engine attribute See merge request gitlab-org/gitlab!56705
-
Clint Cameron authored
Update code_quality.md - I'm a product marketing manager with SonarSource. My intention with this revision is that we (SonarSource) are ok to not get attribution for our engines (our Java, PHP & Python analyzers) and feel it is only fair that Code Climate does receive attribution/credit either.
-
Mayra Cabrera authored
Migration: add trial extension type to gitlab_subscription See merge request gitlab-org/gitlab!56460
-
Qingyu Zhao authored
-
Dylan Griffith authored
Combine tests in `gfm_autocomplete_spec.rb` for performance See merge request gitlab-org/gitlab!56369
-
Scott Hampton authored
Replace hint destination add_remove_clusters with add_eks_clusters See merge request gitlab-org/gitlab!56167
-
Craig Norris authored
Fix tier badge in environments page See merge request gitlab-org/gitlab!56786
-
Stan Hu authored
[RUN ALL RSPEC] Show pwd hint only if pwd auth is enabled on sign-in location mail See merge request gitlab-org/gitlab!56783
-
David O'Regan authored
Project Settings Operations h4 Expand/Collapse 4/5 See merge request gitlab-org/gitlab!56274
-
Natalia Tepluhina authored
Move from btn-success to btn-confirm in projects/network directory See merge request gitlab-org/gitlab!56345
-
Yogi authored
-
David O'Regan authored
Move from btn-success to btn-confirm in projects/environments directory See merge request gitlab-org/gitlab!56212
-
Yogi authored
-
Jose Ivan Vargas authored
Adds pipeline editor link on root Ci config files See merge request gitlab-org/gitlab!56563
-
Frédéric Caplette authored
- Adds pipeline editor button on root config file - This takes the user to ci/editor on master branch by default
-
Nick Gaskill authored
Add missing composer install instructions See merge request gitlab-org/gitlab!56795
-
Steve Abrams authored
-
David O'Regan authored
Project Settings Operations h4 Expand/Collapse 3/5 See merge request gitlab-org/gitlab!56273
-
Scott Hampton authored
Remove ci_instance_variables_ui feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56255
-
David O'Regan authored
Add Ability to Edit Freeze Periods See merge request gitlab-org/gitlab!56407
-
Andrew Fontaine authored
Allows users to modify existing freeze periods within the same modal that is used to create them. Uses a nice little higher order function to keep the same request/receive path as adding a new freeze period.
-
Andrew Fontaine authored
Add btn-default class for Service Desk toggle in settings See merge request gitlab-org/gitlab!56195
-
Kerri Miller authored
Improve `epics/gfm_autocomplete_spec.rb` spec See merge request gitlab-org/gitlab!56389
-
Arturo Herrero authored
Remove duplicate paths from an internal API serializer [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55800
-
Achilleas Pipinellis authored
-
Paul Slaughter authored
Test vulnerability details entry file See merge request gitlab-org/gitlab!55443
-
Marcin Sedlak-Jakubowski authored
Add iteration list docs See merge request gitlab-org/gitlab!56646
-
Simon Knox authored
Perhaps we should instead combine the different Add list sections into a single one, as showing basically the same text and screenshot for each list type doesn't seem very necessary
-
Roger Meier authored
-
Rémy Coutable authored
Refactor Labkit::Context to Gitlab::ApplicationContext See merge request gitlab-org/gitlab!56217
-
Andrew Fontaine authored
-
Scott Hampton authored
Update placeholders for DAST Profile sensitive fields See merge request gitlab-org/gitlab!56496
-
Dheeraj Joshi authored
This updates DAST request headers and password fields which are sensitive in nature
-
drew cimino authored
We're removing some duplicated fields that are no longer used by the frontend. since it's a hard removal of the field, we're putting the change behind a feature falg out of an abundance of caution.
-
Scott Hampton authored
Refactor stages dropdown spec to use VTU See merge request gitlab-org/gitlab!56031
-
Payton Burdette authored
Moving the spec over to use vue test utils and more modern practices.
-
Rémy Coutable authored
Prevent markdownlint errors See merge request gitlab-org/gitlab!56703
-
Marcin Sedlak-Jakubowski authored
Epic boards documentation See merge request gitlab-org/gitlab!56725
-
Florie Guibert authored
-