- 29 Jan, 2020 40 commits
-
-
Heinrich Lee Yu authored
The query was passing a string for file_type when it is an int. This is actually an unused column but was working in Rails 5 because it was just coerced to 0 which is the default value. In Rails 6, it is now nil so no records match our query
-
Heinrich Lee Yu authored
In Rails 6, after_commit callbacks are no longer called unless the model was saved
-
Heinrich Lee Yu authored
The behavior of this is going to change in Rails 6.1 where.not(a: 1, b: 2) is going to be: WHERE (a != 1 OR b !=2 ) instead of WHERE (a != 1 AND b != 2)
-
Heinrich Lee Yu authored
Previously, having the `where` turned this into a relation so `ActiveRecord::Relation#delete_all` is called. In Rails 6, `ActiveRecord::Associations::CollectionProxy#delete_all` is called causing an error in the query.
-
Heinrich Lee Yu authored
* Disable locking at the class-level for `update_all` * Fixes DEPRECATION WARNING: `ActiveRecord::Result#to_hash` has been renamed to `to_a`. `to_hash` is deprecated and will be removed in Rails 6.1. * Fix lookup of CE views `view_paths=` was removed so we just create a new LookupContext here instead of duplicating then modifying the paths * Fix some view related spec failures * Fix database configuration for connection pools ActiveRecord::Base.configurations now returns a ActiveRecord::DatabaseConfigurations object
-
Heinrich Lee Yu authored
We use `present_members` here so that associations are preloaded. We do this even if there's only one record here because it raises an exception when user.status isn't preloaded.
-
Heinrich Lee Yu authored
In Rails 6, content_type now returns the complete header. We use media_type to just get the MIME type portion See https://github.com/rails/rails/pull/36034
-
Heinrich Lee Yu authored
Removes patches that are already in Rails 6: Gitlab::ContentDisposition patch ActiveRecord::QueryCache patch ActiveJob::Arguments patch Gitlab::ActionViewOutput patch Updates Activerecord::Locking::Optimistic patch to follow changes in https://github.com/rails/rails/blob/v6.0.1/activerecord/lib/active_record/locking/optimistic.rb Fix missing timezone for datetime_with_timezone by adding this custom type to ActiveRecord's time_zone_aware_attributes
-
Heinrich Lee Yu authored
There are also minor changes to keep the Rails generated files similar to when generating a new Rails 6 application grape_logging was upgraded to fix deprecation messages related to ActionDispatch::Http::ParameterFilter Rails 6 now adds the nonce to style-src by default. We disable this because we still have a lot of code that set inline styles and we need 'unsafe-inline'
-
Stan Hu authored
Move SpamCheckService into spam folder See merge request gitlab-org/gitlab!23915
-
Douglas Barbosa Alexandre authored
Support design repo in project namespace transfer See merge request gitlab-org/gitlab!23573
-
Mayra Cabrera authored
Delete a comment See merge request gitlab-org/gitlab!23937
-
Lucy Fox authored
-
James Lopez authored
Add a `class_name: "::Project"` to a `belongs_to :project` in a spec Closes #199424 See merge request gitlab-org/gitlab!23979
-
Nick Thomas authored
Merge branch '39505-extend-the-ability-to-clone-a-dashboard-so-it-would-copy-the-custom-metrics' into 'master' Extend the ability to clone a dashboard so it would copy the custom metrics See merge request gitlab-org/gitlab!21923
-
Rémy Coutable authored
Fix missing 'Pipeline schedules' link Closes #199088 See merge request gitlab-org/gitlab!23842
-
Adam Hegyi authored
- Add test case for FOSS and EE project and group navbar structure.
-
Rémy Coutable authored
Feature flag: adding of use_core_delta_islands See merge request gitlab-org/gitlab!23850
-
Natalia Tepluhina authored
Remove Elastic Stack cluster application feature flag See merge request gitlab-org/gitlab!23058
-
Adrien Kohlbecker authored
Enable the app by default
-
Mikolaj Wawrzyniak authored
To make metrics dashboard clonning fully function, we need to inclued custom metrics defined by user.
-
Achilleas Pipinellis authored
Update Dependency Proxy to ultimate only See merge request gitlab-org/gitlab!23925
-
Tim Rizzi authored
-
Achilleas Pipinellis authored
update link to BATS See merge request gitlab-org/gitlab!23866
-
Mikolaj Wawrzyniak authored
-
Achilleas Pipinellis authored
docs: Revise upgrade versions in update readme See merge request gitlab-org/gitlab!23952
-
Rémy Coutable authored
-
Rémy Coutable authored
Optimize ref name lookups in archive downloads See merge request gitlab-org/gitlab!23890
-
Achilleas Pipinellis authored
More explicit Praefect documentation See merge request gitlab-org/gitlab!23853
-
Zeger-Jan van de Weg authored
After another demo with the team, the configuration docs weren't explicit enough. This change updates the docs to be even more explicit.
-
Nick Thomas authored
Add only backend API for view arbitrary commit in merge request - issue #62817 See merge request gitlab-org/gitlab!23701
-
Anwar Sadath authored
-
Martin Wortschack authored
Fix nav link in security submenu See merge request gitlab-org/gitlab!23775
-
Martin Wortschack authored
Changed color of allowed to fail badge from danger to warning See merge request gitlab-org/gitlab!23437
-
Dimitrie Hoekstra authored
The color was not inline with our color design guidelines and was giving off the impression of an error.
-
Andreas Brandl authored
Allow custom Guard command See merge request gitlab-org/gitlab!23947
-
Stan Hu authored
Upgrade Gitaly to v1.85.0 See merge request gitlab-org/gitlab!23945
-
GitalyBot authored
This upgrade deprecates the branch parameter in UserSquash and removes the revision parameter from GetAllLFSPointersRequest.
-
Kamil Trzciński authored
Make attr_encrypted thread-safe Closes #199083 See merge request gitlab-org/gitlab!23955
-
Kushal Pandya authored
Fixed Vue file browser not working with special characters Closes #199308 See merge request gitlab-org/gitlab!23921
-