Merge remote-tracking branch 'origin-ee/feature/intermediate/32568-adding-variables-to-pipelines-schedules-ee' into ce-to-ee-2017-07-08

Port "Add Group secret variables" to EE

See merge request !2373

Show Slack button when there is no team added

See merge request !2381

Fix GitLab Slack application configuration

See merge request !2392

Exclude gitlab_git_test from docs only changes

See merge request !2371

Mark a subgroup-related spec as PostgreSQL-only

Closes #34847

See merge request !12722

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec

Copyedit docs for group-level secret variables

[ci skip]

Wrap additional routes by dash(-). And remove those routes from path_regex.rb.

Add dash for GROUP_ROUTES

Fix variables_controller.rb and format

ayufan nice catches

Use ancestors for avoiding N queries

Add CASE When Clause for saving order when using where IN

secret_variables_for: rails readability versino

Adopt project_variable_path instead of namespace_project_variable_path. (Resolve confilct from master)

gb nice catches

Use new project_variables_path in this MR

Fix to Variable was successfully created

Use variable_params && variable_params_attributes in project variables_controller.rb

Name as variable_params like project variable controller

[EE] Change gitlab_sign_in to sign_in

See merge request !2255

* master-ce: (226 commits)
  fix milestones finder failing spec
  Make wrong migrations idempotent
  Remove double border on last group row
  Username and password are no longer stripped from import url on import
  Send Gitaly Repository with /api/internal/allowed
  Resolve "Liberation Mono weird font rendering on Fedora/openSUSE/other Linux distros"
  Force mobile view for admin projects
  fix spec
  Mark a subgroup-related spec as PostgreSQL-only
  Add members-list class to admin projects page
  Fix another typo in SHA attribute spec
  fix migrations in the future
  Fix SVG scaling issue
  Fix missing `row` & `container` classes
  Use unless for force_mobile_view
  Fixed GFM references not being included when update issue inline
  move CreatedAtFilter to concerns folder
  fix created_after
  Add git_blob_load_all_data feature flag
  Fix typo in SHA attribute spec
  ...

Conflicts:
	app/assets/stylesheets/new_sidebar.scss
	app/assets/stylesheets/pages/issuable.scss
	app/controllers/projects/milestones_controller.rb
	app/controllers/projects/variables_controller.rb
	app/finders/users_finder.rb
	app/models/ci/variable.rb
	app/models/issue.rb
	app/models/milestone.rb
	app/models/user.rb
	app/views/ci/variables/_form.html.haml
	app/views/groups/_settings_head.html.haml
	app/views/shared/members/_member.html.haml
	config/application.rb
	db/schema.rb
	spec/finders/users_finder_spec.rb
	spec/requests/api/users_spec.rb
	spec/services/merge_requests/refresh_service_spec.rb

Send Gitaly Repository with /api/internal/allowed

See merge request !12452

Increase parallelism of geo repository sync worker

Closes #2742

See merge request !2351

fix migrations in the future

Closes #34832

See merge request !12719

Username and password are no longer stripped from import url on import

See merge request !12725