- 17 Jan, 2021 2 commits
-
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
- 16 Jan, 2021 8 commits
-
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
-
Alex Kalderimis authored
Specifically, we want to allow `:read_group`, without which certain policy checks will fail. This was implemented in support of https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40088, but can be extracted in advance, and fixes a distinct bug. The basic assumption of policies is that if `A` delegates to `B` and user `U` is allowed to perform action `x` on `B`, then that user is allowed to perform that action on `A` (i.e. policies are transitive). The `prevent_all` call in this policy breaks that assumption, which is relied on by GraphQL authorization to hold. Without this fix, the following situation is possible: - there exists a group `G`, which is public - there exists a membership of a user `U` in `G` - `Ability.allowed?(nil, :read_group, G) === true` - `Ability.allowed?(nil, :read_group, U) === false` This means that anonymous users cannot read the membership of public groups, but they **can** read the membership of public projects.
-
Paul Slaughter authored
Align checkbox in system hooks page in admin See merge request gitlab-org/gitlab!50958
-
-
David O'Regan authored
Conditionally show card footer in single group page in admin See merge request gitlab-org/gitlab!51426
-
Yogi authored
-
- 15 Jan, 2021 30 commits
-
-
Kushal Pandya authored
Migrate deprecated modal in modal.vue See merge request gitlab-org/gitlab!46182
-
Nick Gaskill authored
The Test Report Modal in the Merge Request Widget made use of the old Bootstrap modals. In order to be able to use GLModal, we are now persisting the Modal visibility state in VueX.
-
David O'Regan authored
Add gl-badge to CI badges See merge request gitlab-org/gitlab!51547
-
Yogi authored
-
David O'Regan authored
Add gl-badge to CI runners See merge request gitlab-org/gitlab!51548
-
Yogi authored
-
David O'Regan authored
Update Issue Incidents to allow milestones to be used See merge request gitlab-org/gitlab!51456
-
David O'Regan authored
Add milestones to Incidents in both quick actions and the sidebar without adding iterations
-
David O'Regan authored
Add gl-badge to members list badges See merge request gitlab-org/gitlab!51546
-
Yogi authored
-
Denys Mishunov authored
Use a dynamic loader for window.gapi See merge request gitlab-org/gitlab!49512
-
Hordur Freyr Yngvason authored
This MR swaps out an implicit dependency on window.gapi for a lazy loader using a script tag designed around the realities of how gapi needs to be loaded. Previously, we had an implicit global dependency on gapi, relying on a DOMContentLoaded event listener in an entirely different module. This was brittle and held back internal efforts to remove dependencies on the DOMContentLoaded event. See https://gitlab.com/gitlab-org/gitlab/-/issues/284997
-
Marcel Amirault authored
Add video link for Multi project pipelines See merge request gitlab-org/gitlab!50646
-
Dov Hershkovitch authored
-
Kushal Pandya authored
Update canary(next) badge style See merge request gitlab-org/gitlab!50965
-
Kushal Pandya authored
Align loading icon for "Time tracking" in issue sidebar See merge request gitlab-org/gitlab!50974
-
Kushal Pandya authored
Remove unwanted space in "Configure pages" card body See merge request gitlab-org/gitlab!50946
-
Kushal Pandya authored
Align button in boards sidebar settings See merge request gitlab-org/gitlab!50928
-
Kushal Pandya authored
Fix alignment of project tags in project home page See merge request gitlab-org/gitlab!51040
-
Matthias Käppler authored
Add service to revoke DastSiteValidations See merge request gitlab-org/gitlab!51678
-
Philip Cunningham authored
Adds new service to delete passed validations by url_base.
-
Martin Wortschack authored
Merge branch 'djensen-add-attributions-to-productivity-analytics-scatterplot-flag-config' into 'master' Add attributions to PA scatterplot flag definition See merge request gitlab-org/gitlab!51769
-
Martin Wortschack authored
Update text of whats new drawer See merge request gitlab-org/gitlab!51422
-
Marcel Amirault authored
Change new at GitLab to new in GitLab
-
Kerri Miller authored
Remove reset_integrations feature flag See merge request gitlab-org/gitlab!51507
-
Andy Soiron authored
-
Marcel Amirault authored
Remove deprecated variables page See merge request gitlab-org/gitlab!51729
-
Craig Norris authored
Remove page of deprecated variables.
-
Stan Hu authored
Update Gitaly version See merge request gitlab-org/gitlab!51728
-
Marcel Amirault authored
Add walkthrough for setting up private CodeQuality runners See merge request gitlab-org/gitlab!49788
-