• Oleg Nesterov's avatar
    will_become_orphaned_pgrp: partially fix insufficient ->exit_state check · 05e83df6
    Oleg Nesterov authored
    p->exit_state != 0 doesn't mean this process is dead, it may have
    sub-threads.  Change the code to use "p->exit_state && thread_group_empty(p)"
    instead.
    
    Without this patch, ^Z doesn't deliver SIGTSTP to the foreground process
    if the main thread has exited.
    
    However, the new check is not perfect either.  There is a window when
    exit_notify() drops tasklist and before release_task().  Suppose that
    the last (non-leader) thread exits.  This means that entire group exits,
    but thread_group_empty() is not true yet.
    
    As Eric pointed out, is_global_init() is wrong as well, but I did not
    dare to do other changes.
    
    Just for the record, has_stopped_jobs() is absolutely wrong too.  But we
    can't fix it now, we should first fix SIGNAL_STOP_STOPPED issues.
    
    Even with this patch ^Z doesn't play well with the dead main thread.
    The task is stopped correctly but do_wait(WSTOPPED) won't see it.  This
    is another unrelated issue, will be (hopefully) fixed separately.
    Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    05e83df6
exit.c 41.5 KB