• Matthieu Baerts's avatar
    mptcp: depends on IPV6 but not as a module · 0ed37ac5
    Matthieu Baerts authored
    Like TCP, MPTCP cannot be compiled as a module. Obviously, MPTCP IPv6'
    support also depends on CONFIG_IPV6. But not all functions from IPv6
    code are exported.
    
    To simplify the code and reduce modifications outside MPTCP, it was
    decided from the beginning to support MPTCP with IPv6 only if
    CONFIG_IPV6 was built inlined. That's also why CONFIG_MPTCP_IPV6 was
    created. More modifications are needed to support CONFIG_IPV6=m.
    
    Even if it was not explicit, until recently, we were forcing CONFIG_IPV6
    to be built-in because we had "select IPV6" in Kconfig. Now that we have
    "depends on IPV6", we have to explicitly set "IPV6=y" to force
    CONFIG_IPV6 not to be built as a module.
    
    In other words, we can now only have CONFIG_MPTCP_IPV6=y if
    CONFIG_IPV6=y.
    
    Note that the new dependency might hide the fact IPv6 is not supported
    in MPTCP even if we have CONFIG_IPV6=m. But selecting IPV6 like we did
    before was forcing it to be built-in while it was maybe not what the
    user wants.
    Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
    Fixes: 010b430d ("mptcp: MPTCP_IPV6 should depend on IPV6 instead of selecting it")
    Signed-off-by: default avatarMatthieu Baerts <matthieu.baerts@tessares.net>
    Link: https://lore.kernel.org/r/20201021105154.628257-1-matthieu.baerts@tessares.netSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
    0ed37ac5
Kconfig 1004 Bytes