• Steve Wise's avatar
    RDMA/iwcm: Don't touch cm_id after deref in rem_ref · 6b59ba60
    Steve Wise authored
    rem_ref() calls iwcm_deref_id(), which will wake up any blockers on
    cm_id_priv->destroy_comp if the refcnt hits 0.  That will unblock
    someone in iw_destroy_cm_id() which will free the cmid.  If that
    happens before rem_ref() calls test_bit(IWCM_F_CALLBACK_DESTROY,
    &cm_id_priv->flags), then the test_bit() will touch freed memory.
    
    The fix is to read the bit first, then deref.  We should never be in
    iw_destroy_cm_id() with IWCM_F_CALLBACK_DESTROY set, and there is a
    BUG_ON() to make sure of that.
    Signed-off-by: default avatarSteve Wise <swise@opengridcomputing.com>
    Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
    6b59ba60
iwcm.c 28.8 KB