• Yuchung Cheng's avatar
    tcp: fix reordering SNMP under-counting · 2d2517ee
    Yuchung Cheng authored
    Currently the reordering SNMP counters only increase if a connection
    sees a higher degree then it has previously seen. It ignores if the
    reordering degree is not greater than the default system threshold.
    This significantly under-counts the number of reordering events
    and falsely convey that reordering is rare on the network.
    
    This patch properly and faithfully records the number of reordering
    events detected by the TCP stack, just like the comment says "this
    exciting event is worth to be remembered". Note that even so TCP
    still under-estimate the actual reordering events because TCP
    requires TS options or certain packet sequences to detect reordering
    (i.e. ACKing never-retransmitted sequence in recovery or disordered
     state).
    Signed-off-by: default avatarYuchung Cheng <ycheng@google.com>
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarNeal Cardwell <ncardwell@google.com>
    Signed-off-by: default avatarSoheil Hassas Yeganeh <soheil@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2d2517ee
tcp_input.c 183 KB