• Ivan Delalande's avatar
    proc/sysctl: don't return ENOMEM on lookup when a table is unregistering · ea5751cc
    Ivan Delalande authored
    proc_sys_lookup can fail with ENOMEM instead of ENOENT when the
    corresponding sysctl table is being unregistered. In our case we see
    this upon opening /proc/sys/net/*/conf files while network interfaces
    are being deleted, which confuses our configuration daemon.
    
    The problem was successfully reproduced and this fix tested on v4.9.122
    and v4.20-rc6.
    
    v2: return ERR_PTRs in all cases when proc_sys_make_inode fails instead
    of mixing them with NULL. Thanks Al Viro for the feedback.
    
    Fixes: ace0c791 ("proc/sysctl: Don't grab i_lock under sysctl_lock.")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarIvan Delalande <colona@arista.com>
    Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
    ea5751cc
proc_sysctl.c 41 KB